-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reword comments and fix typo in buildcontext.go #3690
Conversation
|
Welcome @joycecodes! |
Hi @joycecodes. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some slight improvements here, but nothing I would deem too important. But we will need the EasyCLA issues sorted before we can accept this. Please address the issues pointed out by the comment from EasyCLA and let us know if anything doesn't make sense.
pkg/build/nodeimage/buildcontext.go
Outdated
@@ -125,7 +125,7 @@ func (c *buildContext) buildImage(bits kube.Bits) error { | |||
return err | |||
} | |||
|
|||
// pre-pull images that were not part of the build and write CNI / storage | |||
// pre-pull images that were not part of the build and write CNI / Storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storage isn't a proper name here, I don't think it needs to be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CNI is only capitalized because it is an acronym AND a proper name. In this case storage is neither.
pkg/build/nodeimage/buildcontext.go
Outdated
@@ -249,7 +249,7 @@ func (c *buildContext) prePullImagesAndWriteManifests(bits kube.Bits, parsedVers | |||
c.logger.Errorf("Image build Failed! Failed write default Storage Manifest: %v", err) | |||
return nil, err | |||
} | |||
// all builds should install the default storage driver images currently | |||
// all builds should install the default Storage driver images currently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
@joycecodes please sign cncf-cla |
/easycla |
/check-cla |
/easycla |
It looks like maybe your second commit is OK with easycla but not your first one. It would be good to squash commits anyway. You can squash you commits and update it to be the correct author using something like the following: git rebase -i HEAD~2
# change the second commit to squash, fix up combined commit message
git commit --amend --author="First Last <[email protected]>" --no-edit
git push -f origin comments We need to make sure changes are covered by the CLA before we can consider accepting them. |
27528b1
to
7c0f32e
Compare
Thank you for your patience! |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment, the rest looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, joycecodes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Non-functional change.