Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: VM: switch away from Vagrant to Lima #3753

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Oct 8, 2024

Unlike the current version of Vagrant, Lima remains FLOSS, and is easier to debug (at least for myself)

Fix #3750

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2024
@AkihiroSuda AkihiroSuda marked this pull request as ready for review October 8, 2024 09:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2024
Unlike the current version of Vagrant, Lima remains FLOSS,
and is easier to debug (at least for myself)

Signed-off-by: Akihiro Suda <[email protected]>
@aojea
Copy link
Contributor

aojea commented Oct 8, 2024

Cool, thanks for the quick response and fixing this, I've tried to dig a bit on the problem myself and was clueless about how to troubleshoot it. It is a relieve to know I was not the only one 😄

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@aojea
Copy link
Contributor

aojea commented Oct 8, 2024

I'm going to hold to merge this first #3752 to keep the images in sync with the hash , cc @BenTheElder

/hold

I will unhold once that merges, thanks for fixing it

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2024
@stmcginnis
Copy link
Contributor

/lgtm

Thank you! Much rather see this than Vagrant.

@aojea
Copy link
Contributor

aojea commented Oct 8, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 10e058c into kubernetes-sigs:main Oct 8, 2024
29 checks passed
@BenTheElder
Copy link
Member

Thanks! I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing CI Job] Fedora VMs jobs started failing because VM can not start
5 participants