Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go 1.13.3 (CVE-2019-17596) #961

Merged

Conversation

tao12345666333
Copy link
Member

full diff golang/go@go1.13.1...go1.13.3

go1.13.2 (released 2019/10/17) includes security fixes to the crypto/dsa package and the compiler. See the Go 1.13.2 milestone on our issue tracker for details.

go1.13.3 (released 2019/10/17) includes fixes to the go command, the toolchain, the runtime, syscall, net, net/http, and crypto/ecdsa packages. See the Go 1.13.3 milestone on our issue tracker for details.

Signed-off-by: Jintao Zhang <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 18, 2019
@tao12345666333
Copy link
Member Author

Wait for Golang docker image has been published. docker-library/official-images#6805

@BenTheElder
Copy link
Member

/retest

@BenTheElder BenTheElder self-assigned this Oct 18, 2019
@BenTheElder
Copy link
Member

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2019
@tao12345666333
Copy link
Member Author

/retest

@tao12345666333
Copy link
Member Author

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/961/pull-kind-build/1185113192976617474/build-log.txt

Status: Image is up to date for golang:1.13.3
Digest: sha256:6a693fbaba7dd8d816f6afce049fb92b280c588e0a677c4c8db26645e613fc15
Status: Image is up to date for golang:1.13.3
docker: Error response from daemon: failed to mkdir /docker-graph/volumes/kind-build-cache/_data/bin: mkdir /docker-graph/volumes/kind-build-cache/_data/bin: file exists.
See 'docker run --help'.
make: *** [Makefile:39: kind] Error 125
go: downloading github.com/spf13/cobra v0.0.3

pull-kind-build job failed.

@tao12345666333
Copy link
Member Author

/test pull-kind-build

@k8s-ci-robot k8s-ci-robot merged commit 2a64dbe into kubernetes-sigs:master Oct 18, 2019
@tao12345666333 tao12345666333 deleted the upgrade-to-golang-1.13.3 branch October 18, 2019 09:23
@BenTheElder
Copy link
Member

hmm that is a flake in the cross build

@BenTheElder BenTheElder mentioned this pull request Oct 20, 2019
@tao12345666333
Copy link
Member Author

emmm I am on vacation.

@BenTheElder
Copy link
Member

BenTheElder commented Oct 20, 2019 via email

@tao12345666333
Copy link
Member Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants