Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deflake cross.sh #975

Merged
merged 1 commit into from
Oct 20, 2019
Merged

deflake cross.sh #975

merged 1 commit into from
Oct 20, 2019

Conversation

BenTheElder
Copy link
Member

fixes #974 (I think)

these flakes are blocking the latest binary from being uploaded successfully which is bad for kubernetes CI.
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2019
@BenTheElder BenTheElder mentioned this pull request Oct 20, 2019
Closed
@BenTheElder
Copy link
Member Author

/test pull-kind-build
(succeeded , testing more times)

@BenTheElder
Copy link
Member Author

/test pull-kind-build
passed again, running again

4 similar comments
@BenTheElder
Copy link
Member Author

/test pull-kind-build
passed again, running again

@BenTheElder
Copy link
Member Author

/test pull-kind-build
passed again, running again

@BenTheElder
Copy link
Member Author

/test pull-kind-build
passed again, running again

@BenTheElder
Copy link
Member Author

/test pull-kind-build
passed again, running again

@aojea
Copy link
Contributor

aojea commented Oct 20, 2019 •
edited
Loading

/lgtm

6/6 is a good score to me :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 35fab05 into kubernetes-sigs:master Oct 20, 2019
@BenTheElder
Copy link
Member Author

6/6 is a good score to me :)

we've passed similarly in the PR without this fix though #974 (comment) (which now has this fix)

I guess we'll find out if we see this again afterwards ...

@BenTheElder BenTheElder deleted the say-no-to-flakes branch October 20, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky cross build
3 participants
@BenTheElder @k8s-ci-robot @aojea