add new plugin proxy-port-forward #3387
Conversation
|
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kvaps The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
| Usage: | ||
| $ kubectl proxy-port-forward <local_port>:<remote_host>:<remote_port> [<local_port>:<remote_host>:<remote_port>] | ||
|
|
||
| Example: | ||
| $ kubectl proxy-port-forward 8443:google.com:443 6443:kubernetes.default.svc:443 | ||
| $ curl -k https://localhost:6443 |
There was a problem hiding this comment.
let's remove these from here. they get outdated. this should be in -h/--help of the plugin.
| description: | | ||
| Start socat with proxy to remote host in Kubernetes and forward one or more local ports to it. |
There was a problem hiding this comment.
Q: Are there no caveats to this tool at all, like maybe the pod requires socat?
In the code I see things like kubectl delete pod, which I would not expect this plugin to do. I think this field is a good opportunity to make it clear to users how it works even more.
There was a problem hiding this comment.
The approach is similar to node-shell plugin.
A plugin spawns a new pod with socat to proxy all requests to specified remote hosts, which are available only from Kubernetes cluster.
After usage the pod obviously should be removed.
There was a problem hiding this comment.
I think you explained it really well here. This can be made clear in the description too.
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
Pinging to see if you're interested in updating. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
Ping. |
|
Let's close it for now, since I have no time to maintain this project anymore /close |
|
@kvaps: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A new plugin from
kubectl node-shelldeveloper (me).Might be useful for local development, when you need to proxy multiple services including external ones.