Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding kube-lock plugin #3409

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

ChaosInTheCRD
Copy link
Contributor

Hi there 👋

I wish to add my kubectl toolkube-lock as a krew plugin under the commandlock`. This allows people to easily lock and unlock Kubernetes contexts locally (all performed client side). I have tested it locally and all seems to work fine!

thanks,

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@ahmetb
Copy link
Member

ahmetb commented Oct 9, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @ChaosInTheCRD!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 9, 2023
@ahmetb
Copy link
Member

ahmetb commented Oct 9, 2023

Hi, it's unclear from the description what locking is and what it does. It would be better if you can explain it more clearly.

@ChaosInTheCRD
Copy link
Contributor Author

Hi, it's unclear from the description what locking is and what it does. It would be better if you can explain it more clearly.

Hi Ahmet 👋 - I have updated the description. If it still isn't clear enough then please let me know. I am finding it a little tricky to give more detail within the character limits quoted below:

Eliminate redundant wording form shortDescription (it should be max 50 characters).
Try to word wrap your description to 80-character lines (no usage examples, please).

Ah man i've just realised it isn't an 80 character limit in the description, I misread 🤦‍♀️

@ChaosInTheCRD
Copy link
Contributor Author

Hi 👋

I have updated the description accordingly, hopefully it meets the required standard @ahmetb ?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@ChaosInTheCRD
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@ahmetb
Copy link
Member

ahmetb commented Feb 6, 2024

Would you consider a name like lockctx by any chance? lock is a pretty generic verb and assigning this to this plugin would prevent anyone else from claiming it for a potentially better use.

@ahmetb
Copy link
Member

ahmetb commented Feb 14, 2024

Also I noticed https://github.com/kubernetes-sigs/krew-index/blob/9449d397a524b1608588a824e97ca24800aafca1/plugins/safe.yaml this plugin is somewhat similar. Were you aware of it by any chance?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2024
spec:
version: v0.0.4
homepage: https://github.com/chaosinthecrd/kube-lock
shortDescription: A client-side lock for kubernetes contexts to prevent kubectl misfires.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider shortening to 50 chars in a followup PR.

@ahmetb
Copy link
Member

ahmetb commented May 28, 2024

Sorry for the late review.
/lgtm
/approve
Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ChaosInTheCRD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit d3c150c into kubernetes-sigs:master May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants