-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding kube-lock
plugin
#3409
adding kube-lock
plugin
#3409
Conversation
🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖 Thanks for submitting your kubectl plugin to Krew! In the meanwhile, here are a few tips to make your plugin manifest better:
Thanks for your patience! |
Welcome @ChaosInTheCRD! |
Hi, it's unclear from the description what locking is and what it does. It would be better if you can explain it more clearly. |
Hi Ahmet 👋 - I have updated the description. If it still isn't clear enough then please let me know. I am finding it a little tricky to give more detail within the character limits quoted below:
Ah man i've just realised it isn't an 80 character limit in the description, I misread 🤦♀️ |
Hi 👋 I have updated the description accordingly, hopefully it meets the required standard @ahmetb ? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Would you consider a name like |
Also I noticed https://github.com/kubernetes-sigs/krew-index/blob/9449d397a524b1608588a824e97ca24800aafca1/plugins/safe.yaml this plugin is somewhat similar. Were you aware of it by any chance? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
spec: | ||
version: v0.0.4 | ||
homepage: https://github.com/chaosinthecrd/kube-lock | ||
shortDescription: A client-side lock for kubernetes contexts to prevent kubectl misfires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider shortening to 50 chars in a followup PR.
Sorry for the late review. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, ChaosInTheCRD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi there 👋
I wish to add my kubectl tool
kube-lock as a krew plugin under the command
lock`. This allows people to easily lock and unlock Kubernetes contexts locally (all performed client side). I have tested it locally and all seems to work fine!thanks,