Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subm plugin #3432

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add subm plugin #3432

merged 1 commit into from
Nov 23, 2023

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Oct 17, 2023

subm is a CLI tool that simplifies the deployment and maintenance of Submariner by automating interactions with the Submariner Operator and providing diagnostic features.

Submariner enables direct networking between Pods and Services in different Kubernetes clusters, either on-premises or in the cloud.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Jaanki / name: Janki Chhatbar (e78d0ef)

@ahmetb
Copy link
Member

ahmetb commented Oct 17, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


Thanks for submitting your kubectl plugin to Krew!
One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience!
/kind new-plugin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Jaanki!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 17, 2023
@Jaanki
Copy link
Contributor Author

Jaanki commented Oct 17, 2023

/assign Jaanki

@ahmetb
Copy link
Member

ahmetb commented Oct 17, 2023

/lgtm
/approve
Thanks!

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 17, 2023
@Jaanki
Copy link
Contributor Author

Jaanki commented Oct 19, 2023

@ahmetb the job is failing due to missing LICENSE file in the tar. I was aware that the LICENSE file is a requirement. This would mean a code change in Submariner and then make a new release and link that new release in this PR.

Any chance the test could be over-written to pass?

@ahmetb
Copy link
Member

ahmetb commented Oct 19, 2023

Why not wait for a release?

@ahmetb
Copy link
Member

ahmetb commented Nov 19, 2023

Ping, in case you now have a LICENSE file.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2023
`subm` is a CLI tool that simplifies the deployment and maintenance of
Submariner by automating interactions with the Submariner Operator and
providing diagnostic features.

Submariner enables direct networking between Pods and Services in
different Kubernetes clusters, either on-premises or in the cloud.

Signed-off-by: Janki Chhatbar <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2023
@Jaanki
Copy link
Contributor Author

Jaanki commented Nov 21, 2023

@ahmetb updated the PR to include LICENSE file.

@Jaanki
Copy link
Contributor Author

Jaanki commented Nov 23, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 23, 2023
@ahmetb
Copy link
Member

ahmetb commented Nov 23, 2023

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, Jaanki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5fa0301 into kubernetes-sigs:master Nov 23, 2023
3 checks passed
@Jaanki Jaanki deleted the subm-plugin branch November 28, 2023 13:00
@Jaanki
Copy link
Contributor Author

Jaanki commented Dec 4, 2023

The krew release automation PR to automatically send version updates to krew-index repo is submariner-io/releases#874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/new-plugin lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants