Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate timeout pr, bump versions #3441

Closed
wants to merge 1 commit into from

Conversation

mlbiam
Copy link
Contributor

@mlbiam mlbiam commented Oct 19, 2023

No description provided.

@ahmetb
Copy link
Member

ahmetb commented Oct 19, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/oulogin.yaml is not a straightforward version bump: version should move forward ("v0.0.7" vs "v0.0.3")
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mlbiam
Once this PR has been reviewed and has the lgtm label, please assign corneliusweig for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/plugin-update Version or manifest updates for existing plugins label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2023
@ahmetb
Copy link
Member

ahmetb commented Oct 20, 2023

/hold
@mlbiam can you explain this PR please? I think I've previously asked for integrating with release automation and I have not heard back from you. And I am now noticing you're downgrading a plugin version. This sort of stuff is causing manual burden to reviewers.So I need answers before proceeding

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@mlbiam
Copy link
Contributor Author

mlbiam commented Oct 21, 2023

i couldn't get squahsing to work, so i deleted my fork and re-forked but coppied in the wrong oulogin.yaml. Sorry about that. I now have the automation working and there's an open pr for that so i'll close this.

@mlbiam mlbiam closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/plugin-update Version or manifest updates for existing plugins size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants