Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v0.5.0-rc.2 of klock #3469

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.5.0-rc.2 of klock on behalf of @applejag.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Nov 3, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/klock.yaml is not a straightforward version bump: version should have metadata ("rc.2"), only no pre-release versions are auto-approved
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign chriskim06 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2023
@applejag
Copy link
Contributor

applejag commented Nov 4, 2023

/close

Superseded by v0.5.0 release (non-rc)

@k8s-ci-robot
Copy link
Contributor

@applejag: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Superseded by v0.5.0 release (non-rc)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@applejag
Copy link
Contributor

applejag commented Nov 4, 2023

Oh I thought the "on behaf of" would count me as author.

@applejag
Copy link
Contributor

applejag commented Nov 4, 2023

/pony Applejack

@k8s-ci-robot
Copy link
Contributor

@applejag: pony image

In response to this:

/pony Applejack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@applejag
Copy link
Contributor

applejag commented Nov 4, 2023

#3473 (v0.5.0) has now been merged. Merging this PR would result in a downgrade, which we don't want

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmetb
Copy link
Member

ahmetb commented Nov 22, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants