Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v0.17.1 of tail #3488

Conversation

krew-release-bot
Copy link
Contributor

hey krew-index team,

I am krew-release-bot, and I would like to open this PR to publish version v0.17.1 of tail on behalf of @mnaser.

Thanks,
@krew-release-bot

@ahmetb
Copy link
Member

ahmetb commented Nov 14, 2023

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/tail.yaml is not a straightforward version bump: change on line 5 does not seem like a version bump: [+ selector:]
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krew-release-bot
Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2023
@mnaser
Copy link

mnaser commented Nov 15, 2023

FYI, the goal / intent was to add Windows support. Let me know if we messed up something somewhere :x

@ahmetb
Copy link
Member

ahmetb commented Nov 16, 2023

@ahmetb
Copy link
Member

ahmetb commented Nov 19, 2023

W1114 20:10:34.770304 3766 install.go:164] failed to install plugin "tail": install failed: failed while moving files to the installation directory: failed to move files: failed moving files: could not find move targets: no files in the plugin archive matched the glob pattern=kail

I think from: should be ending with .exe for Windows binaries. @mnaser

@ahmetb
Copy link
Member

ahmetb commented Nov 22, 2023

/close
since we can't iterate on this bot generated PR

@k8s-ci-robot
Copy link
Contributor

@ahmetb: Closed this PR.

In response to this:

/close
since we can't iterate on this bot generated PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants