-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autons
plugin manifest
#3498
Conversation
Welcome @ragrag! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission.
plugins/autons.yaml
Outdated
spec: | ||
version: v0.2.2 | ||
homepage: https://github.com/ragrag/kubectl-autons | ||
shortDescription: Automatic namespace detection for kubectl commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last 3 words are redundant
plugins/autons.yaml
Outdated
homepage: https://github.com/ragrag/kubectl-autons | ||
shortDescription: Automatic namespace detection for kubectl commands | ||
description: | | ||
Automatically detect namespaces for resources in kubectl commands and adding the --namespace flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider wrapping at 80 chars
plugins/autons.yaml
Outdated
description: | | ||
Automatically detect namespaces for resources in kubectl commands and adding the --namespace flag | ||
caveats: | | ||
* In cases where a resource is found in multiple namespaces, an error is expected and you will have to specify the desired namespace manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not so much of a caveat about the plugin itself IMO, you can omit it and it's safe behavior already.
/lgtm Thanks! After this merges, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, ragrag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Ahmet Alp Balkan <[email protected]>
/lgtm |
/hold cancel |
Adding kubectl-autons plugin
autons
automatically detects namespaces for kubectl commands and adds the corresponding --namespace flag.e.g:
running
kubectl autons logs my-pod
wheremy-pod
is in namespaceprod
,autons
will runkubectl autons logs my-pod --namespace prod