Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autons plugin manifest #3498

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Conversation

ragrag
Copy link
Contributor

@ragrag ragrag commented Nov 18, 2023

Adding kubectl-autons plugin

autons automatically detects namespaces for kubectl commands and adds the corresponding --namespace flag.

e.g:
running kubectl autons logs my-pod where my-pod is in namespace prod, autons will run kubectl autons logs my-pod --namespace prod

Copy link

linux-foundation-easycla bot commented Nov 18, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 18, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @ragrag!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 18, 2023
Copy link
Member

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission.

spec:
version: v0.2.2
homepage: https://github.com/ragrag/kubectl-autons
shortDescription: Automatic namespace detection for kubectl commands
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last 3 words are redundant

homepage: https://github.com/ragrag/kubectl-autons
shortDescription: Automatic namespace detection for kubectl commands
description: |
Automatically detect namespaces for resources in kubectl commands and adding the --namespace flag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider wrapping at 80 chars

description: |
Automatically detect namespaces for resources in kubectl commands and adding the --namespace flag
caveats: |
* In cases where a resource is found in multiple namespaces, an error is expected and you will have to specify the desired namespace manually
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not so much of a caveat about the plugin itself IMO, you can omit it and it's safe behavior already.

@ragrag ragrag requested a review from ahmetb November 18, 2023 19:21
plugins/autons.yaml Outdated Show resolved Hide resolved
@ahmetb
Copy link
Member

ahmetb commented Nov 19, 2023

/lgtm
/approve
/hold
in case you want to address that one comment.

Thanks!

After this merges, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ragrag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2023
Co-authored-by: Ahmet Alp Balkan <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2023
@ahmetb
Copy link
Member

ahmetb commented Nov 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2023
@ahmetb
Copy link
Member

ahmetb commented Nov 22, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1f7f12f into kubernetes-sigs:master Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants