Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashwatch-update-1.1.0 #4285

Merged

Conversation

bedirhangull
Copy link
Contributor

No description provided.

@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2024

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖


This pull request does not seem to be a straightforward version bump. I'll have a human review this. If we don't respond within a day, feel free to ping us.

Why wasn't this detected as a plugin version bump:

file plugins/crashwatch.yaml is not a straightforward version bump: could not parse version string "v1.0.6\" "
/kind plugin-update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot added kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2024
Comment on lines 94 to +99
caveats: |
Usage:
$ kubectl crashwatch

For additional options:
$ kubectl crashwatch --help
or visit the documentation at https://github.com/bedirhangull/kubectl-crashwatch/blob/v1.0.6/README.md

or visit the documentation at https://github.com/bedirhangull/kubectl-crashwatch/blob/v1.1.0/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi this part is redundant

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, bedirhangull

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2024

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

@bedirhangull
Copy link
Contributor Author

@ahmetb Yes, I saw it. But when I tried to update my plugin, the bot didn't update my 256 section. I didn't understand how to update automatically. Sorry :( I will not make this mistake again.

@ahmetb
Copy link
Member

ahmetb commented Dec 17, 2024

Np. Please see how other plugins handle it you're unclear.

@ahmetb ahmetb merged commit 1f6b978 into kubernetes-sigs:master Dec 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/plugin-update Version or manifest updates for existing plugins size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants