Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names for multgroup layouts #3580

Merged
merged 1 commit into from
Sep 4, 2023
Merged

🐛 (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names for multgroup layouts #3580

merged 1 commit into from
Sep 4, 2023

Conversation

lowang-bh
Copy link
Member

@lowang-bh lowang-bh commented Sep 3, 2023 •
edited
Loading

Fixes #3502

The comments about path of patch file name in config/crd/kustomization.yaml is not correct when enable multigroup

make test passed.
image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 3, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lowang-bh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86 camilamacedo86 changed the title 🌱 fix kustomization yaml's comments about patches file names 🐛 (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names Sep 3, 2023
camilamacedo86
camilamacedo86 requested changes Sep 3, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🥇

Just a few nits:

  • We should only change kustomize/v2 ( v1 is deprecated )
  • We need to run make generate after the changes so that the samples are updated
  • Please, ensure that after the changes you have only one commit ( squash them out ) so that we can get it merged

PS.: Note that I changed the title for we have a better info for the release notes. I hope that you do not mind.

@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2023
@lowang-bh
Copy link
Member Author

Just a few nits:

  • We should only change kustomize/v2 ( v1 is deprecated )
  • We need to run make generate after the changes so that the samples are updated
  • Please, ensure that after the changes you have only one commit ( squash them out ) so that we can get it merged

Got it.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2023
@camilamacedo86 camilamacedo86 changed the title 🐛 (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names 🐛 (kustomize/v2,go/v4): fix kustomization yaml's webhooks patches file names for multgroup layouts Sep 4, 2023
camilamacedo86
camilamacedo86 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

I am happy that you check that we should only use the group in the name for multi-group layouts.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
camilamacedo86
camilamacedo86 reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2023
@camilamacedo86 camilamacedo86 reopened this Sep 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d859ca into kubernetes-sigs:master Sep 4, 2023
21 of 22 checks passed
@lowang-bh lowang-bh deleted the fixPatchYaml branch September 16, 2023 12:50
@nakamasato nakamasato mentioned this pull request Sep 25, 2023
Merged
@lowang-bh lowang-bh mentioned this pull request Apr 14, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@Kavinjsir Kavinjsir Awaiting requested review from Kavinjsir

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent CRD webhook and certmanager patches kustomization for multigroup go/v4 projects
3 participants
@lowang-bh @k8s-ci-robot @camilamacedo86