🐛 (kustomize/v2, go/v4): fix issue to don't set kustomizeconfig.yaml when Webhooks are not enable into the project #3585

lowang-bh · 2023-09-04T14:32:16Z

Description

Fix error in the layout when webhooks are not enable in the project.

Motivation

k8s-ci-robot · 2023-09-04T14:32:26Z

Hi @lowang-bh. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/crd/kustomization.go

lowang-bh · 2023-09-12T08:43:59Z

Can I ask on which part you are currently working. Can I help you in this?

Still need a new test to ensure that the project works fine when no webhooks are enable

camilamacedo86 · 2023-09-13T21:20:26Z

/pull-kubebuilder-e2e-k8s-1-26-6

lowang-bh · 2023-09-13T23:57:02Z

/retest

lowang-bh · 2023-09-24T07:41:38Z

As a follow up we will also need to do like here: #3629

Could you please check this PR and either give your thoughts.

What shall I do now?

k8s-ci-robot · 2023-09-30T01:18:19Z

New changes are detected. LGTM label has been removed.

… and projects without webhooks At present, we scaffold config/crd/patches, kustomizations, and CA injections for every CRD, irrespective of whether webhooks are enabled in the project or not. However, these configurations are only relevant and valid if the project has webhooks. Consequently, for projects without webhooks, this leads to failures as documented in kubebuilder pull request kubernetes-sigs#3585. To address this, we are now introducing a test to ensure that projects without enabled webhooks function correctly and as anticipated. Signed-off-by: Camila Macedo <[email protected]> Co-authored-by: lowang-bh <[email protected]> fix: just generate crd webhooks patches and ca injestions when webhooks are created for those

… and projects without webhooks At present, we scaffold config/crd/patches, kustomizations, and CA injections for every CRD, irrespective of whether webhooks are enabled in the project or not. However, these configurations are only relevant and valid if the project has webhooks. Consequently, for projects without webhooks, this leads to failures as documented in kubebuilder pull request kubernetes-sigs#3585. To address this, we are now introducing a test to ensure that projects without enabled webhooks function correctly and as anticipated. Signed-off-by: Camila Macedo <[email protected]> Co-authored-by: lowang-bh <[email protected]>

camilamacedo86 · 2023-10-02T07:23:12Z

docs/book/src/component-config-tutorial/testdata/project/config/crd/kustomization.yaml

+# configurations:
+# - kustomizeconfig.yaml


Suggested change

# configurations:

# - kustomizeconfig.yaml

#configurations:

#- kustomizeconfig.yaml

We cannot have the space
Also, we should automatically uncomment this one when a webhook is scaffold.

camilamacedo86

Hi @lowang-bh,

By doing the e2e tests I could check that it would still missing few things
So, I used your PR to give your the credit as well and keep you as co-author
See; #3647

Can we close this one in favor of #3647
Could you please help in the review of #3647 for we move forward and get that one merged.

/approved cancel
/lgtm cancel

k8s-ci-robot · 2023-10-02T07:25:12Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lowang-bh
Once this PR has been reviewed and has the lgtm label, please ask for approval from camilamacedo86. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… and projects without webhooks At present, we scaffold config/crd/patches, kustomizations, and CA injections for every CRD, irrespective of whether webhooks are enabled in the project or not. However, these configurations are only relevant and valid if the project has webhooks. Consequently, for projects without webhooks, this leads to failures as documented in kubebuilder pull request kubernetes-sigs#3585. To address this, we are now introducing a test to ensure that projects without enabled webhooks function correctly and as anticipated. Signed-off-by: Camila Macedo <[email protected]> Co-authored-by: lowang-bh <[email protected]>

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2023

k8s-ci-robot requested review from Kavinjsir and varshaprasad96 September 4, 2023 14:32

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2023

lowang-bh force-pushed the fixIssue branch from baf0434 to 24b171e Compare September 4, 2023 14:39

camilamacedo86 reviewed Sep 5, 2023

View reviewed changes

pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/crd/kustomization.go Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2023