-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (go/v4): Add method to allow users distribute the project #3626
✨ (go/v4): Add method to allow users distribute the project #3626
Conversation
ef2277c
to
0fd17cc
Compare
f253a26
to
5c26bfb
Compare
pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/kdefault/kustomization.go
Outdated
Show resolved
Hide resolved
pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/rbac/role.go
Outdated
Show resolved
Hide resolved
5c26bfb
to
1ea2d07
Compare
1ea2d07
to
c530a0e
Compare
77fbe31
to
f97ec3f
Compare
582d60b
to
e1b428b
Compare
e9e1ead
to
6017d70
Compare
7c4353f
to
0e22981
Compare
8477f64
to
8211a99
Compare
HI @dashanji, @Kavinjsir , @Jay-Madden, @LCaparelli, @vbehar, @varshaprasad96 @everettraven This one seems good to fly now. Also, see that we are testing the installer with the e2e tests. /hold |
Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general!
This is a great feature.
I just left some nit and one open question.
8211a99
to
f39e53e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just remembered that I need to push the changes.
Now we have them with your suggestions !!!
I appreciate a lot your help in review.
Please let me know what you think now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@camilamacedo86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Camila! This is a great addition!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like unit tests a failing. Would have to dig deeper, probably import issues, or version bumps in ginko? |
The unit tests are failing for unrelated reason, it was fixed here: #3743 (coverage test bumped with go 1.19 instead of 1.20) Really thank you for your help and support 🥇 |
Description
Proposed Solution
Just generate the YAML with all that should be installed (same kustomize build of make install and make deploy) so that the project can be distributed as usually it is done by many solutions like Operator Prometheus for example, where users can run: kubectl apply -f dist/install.yaml and maintainers can easily project the raw of the file.
Motivation
Closes: #3185
IMPORTANT: For we are able to check out the changes of this PR we must to have here the fix addressed in the PR: #3627 . So this one is blocked until we are able to merge the fix
/hold