Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update kubebuilder demo svg in README #3638

Merged
merged 1 commit into from
Sep 26, 2023
Merged

📖 Update kubebuilder demo svg in README #3638

merged 1 commit into from
Sep 26, 2023

Conversation

MaGaroo
Copy link
Contributor

@MaGaroo MaGaroo commented Sep 26, 2023 •
edited by camilamacedo86
Loading

Hi!
This PR fixes #3609
I also updated scripts/demo/run.sh so the new svg will be reproducible by anyone else.
Also, tried to update the scripts/demo/README.md so the next person's work will be easier.

Closes: #3609

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MaGaroo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 26, 2023
camilamacedo86
camilamacedo86 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🥇
Thank you a lot for your contribution

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2023
camilamacedo86
camilamacedo86 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, MaGaroo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MaGaroo
Copy link
Contributor Author

MaGaroo commented Sep 26, 2023

/retest 😓

@k8s-ci-robot
Copy link
Contributor

@MaGaroo: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-kubebuilder-e2e-k8s-1-26-6
  • /test pull-kubebuilder-e2e-k8s-1-27-3
  • /test pull-kubebuilder-e2e-k8s-1-28-0
  • /test pull-kubebuilder-test

Use /test all to run all jobs.

In response to this:

/retest 😓

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaGaroo
Copy link
Contributor Author

MaGaroo commented Sep 26, 2023

Okay then
/test pull-kubebuilder-e2e-k8s-1-28-0

@MaGaroo
Copy link
Contributor Author

MaGaroo commented Sep 26, 2023

You're definitely a flake. I've seen you before. :)):
/test pull-kubebuilder-e2e-k8s-1-28-0

@k8s-ci-robot k8s-ci-robot merged commit 5360178 into kubernetes-sigs:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@everettraven everettraven Awaiting requested review from everettraven

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gif in the README is outdated
3 participants
@MaGaroo @k8s-ci-robot @camilamacedo86