-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Addressing Deprecated Manager Options #3664
Conversation
Update deprecated manager Options fields
Run goimports
Hi @buraksekili. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution 🥇
It seems great for me
so
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: buraksekili, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR proposes an update to the documentation available at https://book.kubebuilder.io/cronjob-tutorial/empty-main.html#every-journey-needs-a-start-every-program-needs-a-main. The reason for this revision is that the current documentation still references deprecated cache settings, such as
cache.MultiNamespacedCacheBuilder
.Motivation
With the release of controller-runtime v0.15.0, several Manager Options have undergone refactoring and deprecation. As a result, the documentation needs an update since it still refers to old Manager Options.
Related Issue
Fixes #3662