🌱 Rebase with master branch to do a patch release 4.3.1 #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix GoReleaser by adding permission to write content We found an issue to publish the assets when we are trying to publish the release 4.3.0. Therefore, we are adding the content permission to verify if the issue can be solved within
…ter branch - Updated the Quick Start guide to include details on how to work with the master branch. - Linked to the contributing guide for building Kubebuilder locally.
We generate a sample API in the testdata directory using the DeployImage plugin. However, the flag previously contained incorrect information regarding the image that should be used. This fix ensures the correct image is referenced.
…sed installation Enhance e2e test coverage by including scenarios that verify webhook functionality when the installation is performed via the installer.
🌱 Fix incorrect image reference for DeployImage plugin in test data
🌱 e2e tests: increase coverage by validating webhooks with installer-based installation
…v4.3.0 in the doc sample used - Bump sigs.k8s.io/kubebuilder/v4 from 4.2.0 to 4.3.0 in /docs/book/src/simple-external-plugin-tutorial/testdata/sampleexternalplugin/v1. - Resolve compatibility by moving tests to GitHub Actions to use source code directly. - Remove external plugin e2e tests, as they do not run against a cluster, reducing complexity without testing across all k8s versions.
…ugin-tests 🌱 Fix simplify external plugin tests
Upgrade controller-runtime from v0.19.0 to v0.19.1
Upgrade kustomize version from v5.4.3 to v5.5.0
- Upgraded golangci-lint from v1.59 to v1.61. - Fixed issues flagged by new lint rules in v1.61: - Resolved `comment-spacings` errors in api.go by adding spaces after `//` delimiters. - Addressed `govet` error by formatting non-constant strings in `fmt.Errorf`. - Updated `staticcheck` issues in resource.go by replacing `fmt.Errorf` with `errors.New` for static error messages. - Deprecated the `exportloopref` linter, replaced by `copyloopvar` for Go 1.22+.
✨ Upgrade golangci-lint from v1.59 to v1.61 and resolve new lint issues
… action (#4237) Upgrade GoReleaser version from v2.1.0 to v2.3.2 used in the GitHub action
Upgrade controller-gen version used to generate documentation The documenation for the markers are generated automatic. The project currently scaffold solutions using controller-gen 0.16.4 therefore the documentation should either be generated using this version
Added comments to `NewScaffoldCommand` to clarify that the `kubebuilder alpha generate` command is designed for Kubebuilder’s internal use only. The updated go documentation explains that importing this command into other projects is not supported, as it relies on Kubebuilder-specific configurations, key mappings, and plugins, which may not be applicable to other setups. Projects that use Kubebuilder as a library and require similar functionality should implement a custom solution for compatibility with their specific configurations and plugins.
- Integrated SBOM generation in GoReleaser using Syft to produce CycloneDX SBOMs. - Updated GitHub Actions workflow to install Syft, enabling automated SBOM creation on release. - This enhancement is part of ongoing efforts to align with the EU Cyber Resilience Act, ensuring transparency and security in our software supply chain.
- Remove configurations for deprecated branches no longer in use - Change schedule to perform checks daily for up-to-date dependency management - Ensure dependencies in sample projects are properly included in checks
…ed page The Quick Start now has a note that links its page. The info is too verbose and might be not helpful and it is scaring for those that are looking for a Quick Start
Signed-off-by: Thiha Min Thant <[email protected]>
📖 Resolve navigation bar CSS issue and sidebar toggle functionality.
🌱 Update Dependabot configuration
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.2 to 1.35.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.2...v1.35.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…sample (#4273) The go.mod check for sample configuration helps us identify potential required bumps. However, note that go.mod is often updated by controller-runtime, so we can't manually change certain dependencies. Additionally, we only need to check one sample project—there’s no need to duplicate efforts by opening the same PR across all samples.
…ithub.com/onsi/gomega-1.35.0 🌱 Bump github.com/onsi/gomega from 1.34.2 to 1.35.0
Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.20.2 to 2.21.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.20.2...v2.21.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ithub.com/onsi/ginkgo/v2-2.21.0 🌱 Bump github.com/onsi/ginkgo/v2 from 2.20.2 to 2.21.0
📖 move Versions Compatibility and Supportability info to a dedicated page
📖 Correct misleading information in production note for metrics config
…ns/actions/setup-go-5 🌱 Bump actions/setup-go from 4 to 5
Add bundle installer for sample projects in docs Introduces a bundle installer for sample projects, with config/default/kustomization.yaml settings uncommented to ensure complete bundle generation. This enhances review visibility by showing the final state of patches and Kustomize configurations directly in the generated bundle. Motivation: Makes reviews more efficient by displaying final configurations directly in the bundle, with only relevant settings uncommented in config/default/kustomization.yaml for each sample.
…tomization.yaml for better visibility in new projects - Relocated the cert-manager setup block (kind: Service, version: v1, name: webhook-service) to improve user experience. - Change only affects new projects.
…comment 🐛 (kustomize/v2,go/v4): Move cert-manager uncomment block to top of kustomization.yaml for better visibility in new projects
…eate webhook --conversion Ensure config/crd/patches are only generated for CRDs that were created using kubebuilder create webhook --conversion, as these patches are specific to conversion configuration and not needed for other CRDs.
🐛 (kustomize/v2, go/v4): Fix incorrect generation of manifests under config/crd/patches. Previously, the /convert service patch was being generated for all webhooks instead of only for those with --conversion enabled.
Previously, attempting to create multiple webhooks for the same resource with different configurations (e.g., `--defaulting` and `--programmatic-validation`) resulted in an error indicating that the webhook already exists. This update allows multiple webhook types to be scaffolded for a single resource without conflict, providing flexibility for users be able to scaffold different types of webhooks for the same GKV afterwords and without the need to be all by once.
🐛 (go/v4) Fix issue with scaffolding multiple webhooks for the same resource
📖 (doc) - Fix broken URL
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.19.0 to 0.20.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.19.0...v0.20.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…olang.org/x/text-0.20.0 🌱 Bump golang.org/x/text from 0.19.0 to 0.20.0
📖 (doc) - Fix Add missing Reference-style Link
🐛 (go/v4): Fix path configuration for webhook markers generated for core types with non-"core" group values
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.26.0 to 0.27.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…olang.org/x/tools-0.27.0 🌱 Bump golang.org/x/tools from 0.26.0 to 0.27.0
We are reverting the changes done in the PR #4286. We are just keeping the e2e tests improvements. We will not able to solve the issue #4146 without add new markers. We cannot skip the action to write an webhook since it will result in incomplete inplementation in the <kind>_webhook.go as in the <kind>_webhook_test.go
📖 (doc): getting started: fix information about make command for generating manifests
🐛 revert the changes done in the PR #4286
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: #4284