🌱Build the kubebuilder binary before and use it to regenerate the helm chart

[monteiro-renato]

I believe this way is better? Specially now that the helm plugin is not yet available in any released version of kubebuilder?
For me, it also makes testing easier as I can make changes to the code and see it reflected in the generated chart without having to remember to make install beforehand.

[k8s-ci-robot]

Hi @monteiro-renato. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

So we need to call here make install instead right?

[monteiro-renato]

Personally, I never actually use make install, I find it too intrusive.
I prefer to use the binary in the bin folder.

[camilamacedo86]

Ok. So, based on your POV, we might need to leave it as it is.
We recommend using Make Install in all places.

However, it has contributors do not like it, they will prefer as you to build
So, leaving it as it is allows people to have a choice

WDYT?

[monteiro-renato]

In my opinion, it makes sense to use the kubebuilder version built from main since this is regenerating data in the ./testdata directory.
The make generate command, and more specifically, the make generate-testdata command, calls the script in https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh#L123C1-L123C9 which is also building kubebuilder (https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/common.sh#L108-L113) and putting it in a tmp directory instead of relying on the locally installed version.

But feel free to close the PR if you thing it's best to leave it as is.

[camilamacedo86]

Your argumentation is fair enough 👍

[camilamacedo86]

/ok-to-test
/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, monteiro-renato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment