🌱improve Ginkgo/Gomega test style #4426
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Sijoma The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @Sijoma. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
| // check that ca should be long enough, because there may be a place holder "\n" | ||
| ExpectWithOffset(2, len(mwhOutput)).To(BeNumerically(">", 10)) | ||
| g.ExpectWithOffset(2, len(mwhOutput)).To(BeNumerically(">", 10)) |
There was a problem hiding this comment.
The idea is to follow the same approach as the test scaffolds: https://github.com/kubernetes-sigs/kubebuilder/tree/master/testdata/project-v4/test (as closer as possible is the ideal, same standards of checks)
If you look there, you will see that it is quite similar to what we do here. You can indeed compare the same checks for metrics etc.
For example, we should no longer use ExpectWithOffset; instead, we should use the functions and simplify it.
Look at #4135
And check the PRs done by @mogsie related to the tests: https://github.com/kubernetes-sigs/kubebuilder/pulls?q=is%3Apr+author%3Amogsie+is%3Aclosed
I think that will help out understand better what we are trying to do,
BTW, thank you a lot for checking this one
Updates a couple of e2e tests to use Gomega style mentioned in #4135 .
I'm not sure if I 100% understood the issue so before I try to rewrite all of them I thought it would be better to create a smaller PR to get feedback earlier.
relates #4424