✨ feat: add webhook CertWatcher and flags for custom certificate configuration #4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilamacedo86
commented
Dec 14, 2024
camilamacedo86
commented
- Introduced CertWatcher for webhook server to dynamically reload certificates.
- Added CLI flags (--webhook-cert-path, --webhook-cert-name, --webhook-cert-key) to allow users to provide custom certificate paths.
- Updated manager to integrate CertWatcher into webhook TLS options.
- Ensured backward compatibility with default self-signed certificates if no custom certs are provided.
k8s-ci-robot
added
cncf-cla: yes
…uration - Introduced CertWatcher for webhook server to dynamically reload certificates. - Added CLI flags (--webhook-cert-path, --webhook-cert-name, --webhook-cert-key) to allow users to provide custom certificate paths. - Updated manager to integrate CertWatcher into webhook TLS options. - Ensured backward compatibility with default self-signed certificates if no custom certs are provided.
camilamacedo86
force-pushed
the
webhook-watcher
branch
from
1421b14 to
489145d
Compare
varshaprasad96
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Just one nit, rest looks good!
Thanks @camilamacedo86!
/lgtm
| var webhookCertWatcher *certwatcher.CertWatcher | ||
|
|
||
| // Initial webhook TLS options | ||
| webhookTLSOpts := append([]func(*tls.Config){}, tlsOpts...) |
There was a problem hiding this comment.
nit:
Suggested change
| webhookTLSOpts := append([]func(*tls.Config){}, tlsOpts...) | |
| webhookTLSOpts := tlsOpts |
as the slice is already initialised in line 84, and we should be able to append to it.
There was a problem hiding this comment.
Done that here: https://github.com/kubernetes-sigs/kubebuilder/pull/4400/files
Where we put all together and shape things
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.