Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running kubetest2-gke --down separately, does not delete clusters create by --up previously #112

Open
chrislovecnm opened this issue Mar 16, 2021 · 8 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@chrislovecnm
Copy link
Contributor

Hi all

I am running kubetest2 gke --down --cluster-name bazel-test --project chris-love-operator-playground --zone us-central1-a --ignore-gcp-ssh-key and the gke cluster is not getting deleted.

kubetest2 gke --up --cluster-name bazel-test --project chris-love-operator-playground --zone us-central1-a --ignore-gcp-ssh-key created the cluster

@amwat
Copy link
Contributor

amwat commented Mar 16, 2021

Decoupled --up --down in general doesn't have good support yet, but we do want that eventually.

The intended way would be to run --down with the --run-id=<run id used during up> (this also doesn't work currently though).

/cc @chizhg

currently the projectClusterLayout is stored in-memory, we'll want to persist that under RunDir() for Down() to reuse.
Note: some of this is being planned to be tackled in #88 (comment)

@chizhg
Copy link
Contributor

chizhg commented Mar 16, 2021

/cc @joshua-bone

@chrislovecnm
Copy link
Contributor Author

@amwat is there a good way to exec a test command while running an --up --down? We need to run a bazel e2e test

@amwat
Copy link
Contributor

amwat commented Mar 16, 2021

Yup, you can use the exec tester.
kubetest2 gke --up --down --test=exec -- <mycommand or myscript.sh>

@chrislovecnm
Copy link
Contributor Author

Yah I am trying

~/Workspace/bin/kubetest2 gke --down --cluster-name kubetest2 --project chris-love-operator-playground --zone us-central1-a --ignore-gcp-ssh-key --up --test=exec -- bazel test --stamp //e2e/... --test_arg=--pvc=true

@amwat
Copy link
Contributor

amwat commented Mar 19, 2021

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 19, 2021
@amwat amwat changed the title kubetest2-gke -down not deleting cluster Running kubetest2-gke --down separately, does not delete clusters create by --up previously Mar 19, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2021
@amwat
Copy link
Contributor

amwat commented Jun 18, 2021

/remove-lifecycle stale
/lifecycle frozen

Improvements in #88 will also help in this

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2021
@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

6 participants