Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment the kubetest2 gke deployer flags to different groups and some other updates #153

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Segment the kubetest2 gke deployer flags to different groups and some other updates #153

merged 4 commits into from
Aug 25, 2021

Conversation

chizhg
Copy link
Contributor

@chizhg chizhg commented Jul 7, 2021 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from amwat and cofyc July 7, 2021 02:03
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2021
@chizhg chizhg changed the title [WIP] Segment the kubetest2 gke deployer flags to different groups Segment the kubetest2 gke deployer flags to different groups and some other updates Jul 19, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
@chizhg
Copy link
Contributor Author

chizhg commented Jul 26, 2021

/assign @amwat @BenTheElder
Could you help review it when you have time? Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 21, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 21, 2021 •
edited
Loading

@chizhg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
gke-up-down-multicluster 800f475 link /test gke-up-down-multicluster
gke-up-down-singlecluster 800f475 link /test gke-up-down-singlecluster

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chizhg chizhg force-pushed the kubetest2-gke-options branch 2 times, most recently from b170568 to d6a9921 Compare August 22, 2021 21:41
amwat
amwat reviewed Aug 23, 2021
View reviewed changes
kubetest2-gke/deployer/options/project.go
BoskosLocation string `flag:"~boskos-location" desc:"If set, manually specifies the location of the Boskos server."`
BoskosAcquireTimeoutSeconds int `flag:"~boskos-acquire-timeout-seconds" desc:"How long (in seconds) to hang on a request to Boskos to acquire a resource before erroring."`
BoskosHeartbeatIntervalSeconds int `flag:"~boskos-heartbeat-interval-seconds" desc:"How often (in seconds) to send a heartbeat to Boskos to hold the acquired resource. 0 means no heartbeat."`
BoskosResourceType []string `flag:"~boskos-resource-type" desc:"If set, manually specifies the resource type(s) of GCP projects to acquire from Boskos."`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this change?

Copy link
Contributor Author

@chizhg chizhg Aug 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multiproject multicluster topology with shared VPC network, we need at least 3 projects - one is the host project and the other two are the service projects. A host project cannot be used as a service project, and vice versa, so we have to acquire them from 2 different project pools, one from the host project pool and the other two from the service project pool.

Currently for ASM testing we are acquiring these projects out of the kubetest2 gke deployer, and this change is to enable us to acquire the projects with kubetest2.

I have added it to the PR description.

@amwat
Copy link
Contributor

amwat commented Aug 25, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4a03435 into kubernetes-sigs:master Aug 25, 2021
@chizhg chizhg deleted the kubetest2-gke-options branch November 3, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat amwat left review comments

@cofyc cofyc Awaiting requested review from cofyc

Assignees

@BenTheElder BenTheElder

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chizhg @k8s-ci-robot @amwat @BenTheElder