Skip to content

Commit

Permalink
comment out partial managedBy logic
Browse files Browse the repository at this point in the history
  • Loading branch information
dgrove-oss committed Jan 21, 2025
1 parent 65ce7e6 commit c78609d
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions pkg/controller/jobs/appwrapper/appwrapper_multikueue_adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
"k8s.io/klog/v2"
"k8s.io/utils/ptr"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"

Expand Down Expand Up @@ -106,16 +105,19 @@ func (b *multikueueAdapter) KeepAdmissionCheckPending() bool {
}

func (b *multikueueAdapter) IsJobManagedByKueue(ctx context.Context, c client.Client, key types.NamespacedName) (bool, string, error) {
aw := awv1beta2.AppWrapper{}
err := c.Get(ctx, key, &aw)
if err != nil {
return false, "", err
}
awControllerName := ptr.Deref(aw.Spec.ManagedBy, "")
if awControllerName != kueue.MultiKueueControllerName {
return false, fmt.Sprintf("Expecting spec.managedBy to be %q not %q", kueue.MultiKueueControllerName, awControllerName), nil
}
return true, "", nil
/*
aw := awv1beta2.AppWrapper{}
err := c.Get(ctx, key, &aw)
if err != nil {
return false, "", err
}
awControllerName := ptr.Deref(aw.Spec.ManagedBy, "")
if awControllerName != kueue.MultiKueueControllerName {
return false, fmt.Sprintf("Expecting spec.managedBy to be %q not %q", kueue.MultiKueueControllerName, awControllerName), nil
}
return true, "", nil
*/
}

var _ jobframework.MultiKueueWatcher = (*multikueueAdapter)(nil)
Expand Down

0 comments on commit c78609d

Please sign in to comment.