Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise waiting for the availability of CRD-based frameworks #4059

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Horiodino
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added watchCRDs: Introduced a function to monitor CRDs using the apiextensions/v1 API, triggering waitForAPI only when a CRD becomes established.
Integrated watchCRDs into SetupControllers: Spawned a goroutine to watch CRDs and feed discovered GroupVersionKind (GVK) into the discoveredCRDs channel.
Updated setupControllersFromDiscoveredCRDs the logic to dynamically match and register GVKs with integrations based on incoming discoveredCRDs.

Which issue(s) this PR fixes:

Fixes #2837

Special notes for your reviewer:

Draft PR in progress – but feel free to provide any suggestions!

Does this PR introduce a user-facing change?


@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Horiodino
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Horiodino. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2025
Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit b2b032c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/679e12e0dbb5e500081aa8ee
😎 Deploy Preview https://deploy-preview-4059--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mimowo
Copy link
Contributor

mimowo commented Jan 28, 2025

@Horiodino great to see you working on this. Watching the CRDs with the controlller-runtime informer is definitely an option.
cc @varshaprasad96 @ChristianZaccaria @mbobrovskyi
it would be great if you can help with the review.

@mimowo
Copy link
Contributor

mimowo commented Jan 28, 2025

/retitle Optimise waiting for the availability of CRD-based frameworks

@k8s-ci-robot k8s-ci-robot changed the title Optimise current implementation of processing newly added job frameworks Optimise waiting for the availability of CRD-based frameworks Jan 28, 2025
@mbobrovskyi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

@Horiodino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-main 9dbdf00 link true /test pull-kueue-verify-main
pull-kueue-test-e2e-main-1-30 9dbdf00 link true /test pull-kueue-test-e2e-main-1-30
pull-kueue-test-e2e-main-1-31 9dbdf00 link true /test pull-kueue-test-e2e-main-1-31
pull-kueue-test-e2e-main-1-29 9dbdf00 link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-test-e2e-main-1-32 9dbdf00 link true /test pull-kueue-test-e2e-main-1-32
pull-kueue-test-tas-e2e-main 9dbdf00 link true /test pull-kueue-test-tas-e2e-main
pull-kueue-test-multikueue-e2e-main 9dbdf00 link true /test pull-kueue-test-multikueue-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Horiodino
Copy link
Contributor Author

ahhh im not sure why most of e2e failing ,locally all succeeded. need some assistance

Ran 34 of 34 Specs in 23.627 seconds
SUCCESS! -- 34 Passed | 0 Failed | 0 Pending | 0 Skipped


Ginkgo ran 24 suites in 10m48.689090589s
Test Suite Passed
/home/yoi/kueue/bin/ginkgo-top -i /home/yoi/kueue/bin/integration.json > /home/yoi/kueue/bin/integration-top.yaml

@mbobrovskyi
Copy link
Contributor

ahhh im not sure why most of e2e failing ,locally all succeeded. need some assistance

Ran 34 of 34 Specs in 23.627 seconds
SUCCESS! -- 34 Passed | 0 Failed | 0 Pending | 0 Skipped


Ginkgo ran 24 suites in 10m48.689090589s
Test Suite Passed
/home/yoi/kueue/bin/ginkgo-top -i /home/yoi/kueue/bin/integration.json > /home/yoi/kueue/bin/integration-top.yaml

Try to rebase main branch.

@Horiodino Horiodino force-pushed the optimise_current_implementation_of_processing_newly_added_job_frameworks branch from 9dbdf00 to b2b032c Compare February 1, 2025 12:26
@Horiodino
Copy link
Contributor Author

ok , updated

✓  pkg/util/wait (1.147s) (coverage: 0.1% of statements in ./...)
✓  pkg/webhooks (1.165s) (coverage: 2.0% of statements in ./...)
✓  pkg/workload (1.288s) (coverage: 2.8% of statements in ./...)
✓  pkg/visibility/api/v1beta1 (1.33s) (coverage: 2.0% of statements in ./...)
✓  pkg/scheduler (8.356s) (coverage: 14.1% of statements in ./...)

DONE 2220 tests in 27.119s
Ran 33 of 33 Specs in 23.729 seconds
SUCCESS! -- 33 Passed | 0 Failed | 0 Pending | 0 Skipped


Ginkgo ran 22 suites in 11m55.637279503s
Test Suite Passed
/home/yoi/kueue/bin/ginkgo-top -i /home/yoi/kueue/bin/integration.json > /home/yoi/kueue/bin/integration-top.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Enhance/optimise current implementation of processing newly added Job Frameworks.
4 participants