-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise waiting for the availability of CRD-based frameworks #4059
base: main
Are you sure you want to change the base?
Optimise waiting for the availability of CRD-based frameworks #4059
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Horiodino The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Horiodino. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Horiodino great to see you working on this. Watching the CRDs with the controlller-runtime informer is definitely an option. |
/retitle Optimise waiting for the availability of CRD-based frameworks |
/ok-to-test |
@Horiodino: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ahhh im not sure why most of e2e failing ,locally all succeeded. need some assistance
|
Try to rebase main branch. |
Signed-off-by: Horiodino <[email protected]>
Signed-off-by: Horiodino <[email protected]>
9dbdf00
to
b2b032c
Compare
ok , updated
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added watchCRDs: Introduced a function to monitor CRDs using the apiextensions/v1 API, triggering waitForAPI only when a CRD becomes established.
Integrated watchCRDs into SetupControllers: Spawned a goroutine to watch CRDs and feed discovered GroupVersionKind (GVK) into the discoveredCRDs channel.
Updated setupControllersFromDiscoveredCRDs the logic to dynamically match and register GVKs with integrations based on incoming discoveredCRDs.
Which issue(s) this PR fixes:
Fixes #2837
Special notes for your reviewer:
Draft PR in progress – but feel free to provide any suggestions!
Does this PR introduce a user-facing change?