-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make all file headers consistent #4075
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alexandear The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @alexandear. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: 8933e7facf8c998350ad3374258590a1f0e36e80
|
regexp: | ||
CopyrightDate: "Copyright \\d{4}" | ||
template: |- | ||
{{CopyrightDate}} The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{{CopyrightDate}} The Kubernetes Authors. | |
The Kubernetes Authors. |
The current template without year is intended.
We drop the year since we want to avoid the license update every year: #1590
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, could we reuse this template instead of hardcoded one here?
https://github.com/kubernetes-sigs/kueue/blob/main/hack/boilerplate.go.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I investigated PR #1590 before creating this one, and what I understood from the description is that it is only for generated code. This PR touches only human-added files, not the generated files.
In human-added files, there is no issue with updating the year every year. We add the year into license only on introducing a new file.
Are you sure I need to change the copyright template to be the same for human-added and generated files? It requires me to update roughly 6K files. It's not a big deal, just asking to be sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Fixes copyright headers for Go files and make it consistent. Integrates
goheader
linter to automatically check the file header.Special notes for your reviewer:
Changes:
About
goheader
linter: https://golangci-lint.run/usage/linters/#goheaderDoes this PR introduce a user-facing change?