Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #3952: [StatefulSet] Disallow changes to PodSpec fields other than the image field #4078

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Jan 28, 2025

Cherry pick of #3952 on release-0.10.

#3952: [StatefulSet] Disallow changes to PodSpec fields other than the image field

For details on the cherry pick process, see the cherry pick requests page.

NONE

@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2025
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bbef4ef
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6798cdd618f9ed0008209bcb

@mbobrovskyi mbobrovskyi force-pushed the automated-cherry-pick-of-#3952-upstream-release-0.10 branch from dc2f38d to bbef4ef Compare January 28, 2025 12:30
@mbobrovskyi
Copy link
Contributor Author

/assign @mimowo

@mimowo
Copy link
Contributor

mimowo commented Jan 28, 2025

/hold
As discussed offline with @mbobrovskyi we would first investigate if we can allow easily changes to any container fields which don't change the role hash. This will block updates to resources, but allow to changes to not just image but also other fields such as "args". Then, we would cherry-pick both PRs as one with two commits.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 28, 2025
@mimowo
Copy link
Contributor

mimowo commented Feb 5, 2025

/close
This will be replaced by a cherry-pick combining it with #4081

@k8s-ci-robot
Copy link
Contributor

@mimowo: Closed this PR.

In response to this:

/close
This will be replaced by a cherry-pick combining it with #4081

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants