Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] stop using gcr io in tests #4107

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[Cleanup] stop using gcr io in tests #4107

wants to merge 3 commits into from

Conversation

mszadkow
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The gcr.io image registry is deprecated and will be shut down in 2025.
Use busybox instead as discussed here

Which issue(s) this PR fixes:

Fixes #3772

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mszadkow
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 190cfb1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/679c891c1e2bf0000802bcfb
😎 Deploy Preview https://deploy-preview-4107--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2025
@mszadkow
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 30, 2025
@mimowo
Copy link
Contributor

mimowo commented Jan 30, 2025

once ready please repeat the tests 5 times on ci to minimize a chance of flakes. please also report the changes of the test execution times

@mszadkow mszadkow force-pushed the cleanup/stop-using-gcr-io-in-tests branch from a5e8778 to 190cfb1 Compare January 31, 2025 08:26
@mszadkow
Copy link
Contributor Author

/retest

@mszadkow
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-32
/test pull-kueue-test-multikueue-e2e-main
/test pull-kueue-test-tas-e2e-main
/test pull-kueue-test-integration-main

3 similar comments
@mszadkow
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-32
/test pull-kueue-test-multikueue-e2e-main
/test pull-kueue-test-tas-e2e-main
/test pull-kueue-test-integration-main

@mszadkow
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-32
/test pull-kueue-test-multikueue-e2e-main
/test pull-kueue-test-tas-e2e-main
/test pull-kueue-test-integration-main

@mszadkow
Copy link
Contributor Author

/test pull-kueue-test-e2e-main-1-32
/test pull-kueue-test-multikueue-e2e-main
/test pull-kueue-test-tas-e2e-main
/test pull-kueue-test-integration-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using gcr.io images in Kueue for testing
3 participants
@mszadkow @k8s-ci-robot @mimowo