-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add parameters for tuning revisionHistoryLimit and emptyDir volumes #1365
Conversation
Welcome @bodgit! |
Hi @bodgit. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @stevehipwell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bodgit. Could you remove the Chart.yaml changes?
21951a5
to
cd57e11
Compare
@stevehipwell done, I wasn't sure if it was just version bumps or any sort of change. |
@bodgit I've added a syntax suggestion to the ExternalDNS PR. |
/ok-to-test |
@stevehipwell can you take a look here? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bodgit I've explicitly added the feedback here.
@cpanato any idea why the Cosign installer is failing? |
@bodgit please rebase this PR to get the latest changes, that might fix the ci error |
Sorry @cpanato I thought I'd commented on all of the PRs failing Helm chart validation due to needing a rebase. |
no worries :) |
cd57e11
to
9d06047
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
9d06047
to
fa0a554
Compare
Signed-off-by: Matt Dainty <[email protected]>
fa0a554
to
026af89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bodgit, sorry it took so long.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bodgit, stevehipwell, yangjunmyfm192085 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds support for setting the
revisionHistoryLimit
on the Deployment and tuning theemptyDir
volume, (sizeLimit
,medium
, etc.), used for temporary files.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):