Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add parameters for tuning revisionHistoryLimit and emptyDir volumes #1365

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Nov 16, 2023

What this PR does / why we need it:

This PR adds support for setting the revisionHistoryLimit on the Deployment and tuning the emptyDir volume, (sizeLimit, medium, etc.), used for temporary files.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 16, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @bodgit!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @bodgit. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2023
@dgrisonnet
Copy link
Member

/assign @stevehipwell
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 16, 2023
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bodgit. Could you remove the Chart.yaml changes?

@bodgit bodgit force-pushed the chart-enhancements branch from 21951a5 to cd57e11 Compare November 17, 2023 09:37
@bodgit
Copy link
Contributor Author

bodgit commented Nov 17, 2023

Thanks for the PR @bodgit. Could you remove the Chart.yaml changes?

@stevehipwell done, I wasn't sure if it was just version bumps or any sort of change.

@stevehipwell
Copy link
Contributor

@bodgit I've added a syntax suggestion to the ExternalDNS PR.

@cpanato
Copy link
Member

cpanato commented Nov 28, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2023
@cpanato
Copy link
Member

cpanato commented Nov 28, 2023

@stevehipwell can you take a look here? thanks!

Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodgit I've explicitly added the feedback here.

charts/metrics-server/values.yaml Outdated Show resolved Hide resolved
charts/metrics-server/templates/deployment.yaml Outdated Show resolved Hide resolved
@stevehipwell
Copy link
Contributor

@cpanato any idea why the Cosign installer is failing?

@cpanato
Copy link
Member

cpanato commented Dec 4, 2023

@bodgit please rebase this PR to get the latest changes, that might fix the ci error

@stevehipwell
Copy link
Contributor

Sorry @cpanato I thought I'd commented on all of the PRs failing Helm chart validation due to needing a rebase.

@cpanato
Copy link
Member

cpanato commented Dec 4, 2023

no worries :)

@bodgit bodgit force-pushed the chart-enhancements branch from cd57e11 to 9d06047 Compare December 5, 2023 00:23
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@bodgit bodgit force-pushed the chart-enhancements branch from 9d06047 to fa0a554 Compare December 7, 2023 13:26
@bodgit bodgit force-pushed the chart-enhancements branch from fa0a554 to 026af89 Compare December 7, 2023 13:27
@bodgit bodgit requested a review from stevehipwell December 7, 2023 13:44
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bodgit, sorry it took so long.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bodgit, stevehipwell, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit d2772a2 into kubernetes-sigs:master Dec 7, 2023
12 checks passed
@bodgit bodgit deleted the chart-enhancements branch December 12, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants