Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPEP: Add support for egress traffic control #117

Merged
merged 1 commit into from
Sep 20, 2023
Merged

NPEP: Add support for egress traffic control #117

merged 1 commit into from
Sep 20, 2023

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Jun 11, 2023 •
edited
Loading

Supersedes #86
Issue-Tracker: #126

- NOTE: Currently there are no user stories for `Pass` action with northbound traffic
    but users will get this for free since this action is anyways supported in the API.

TODO: Figure out where to add this in our website.

@netlify
Copy link

netlify bot commented Jun 11, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit ebdabbc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/64c8e48e8c429700085a1a95
😎 Deploy Preview https://deploy-preview-117--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2023
@k8s-ci-robot k8s-ci-robot requested review from astoycos and Dyanngg June 11, 2023 19:11
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2023
@astoycos astoycos mentioned this pull request Jun 20, 2023
Closed
@astoycos
Copy link
Member

@tssurya Do we need to add any docs or a template on how/ when to make an NPEP here?

This looks really good as a start.

npinaeva
npinaeva reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@npinaeva npinaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice use cases description!

npeps/npep-28-egress-traffic-control.md Outdated Show resolved Hide resolved
@npinaeva npinaeva mentioned this pull request Jul 12, 2023
Closed
9 tasks
@tssurya tssurya mentioned this pull request Jul 18, 2023
Closed
@tssurya tssurya force-pushed the ANP-egress-control-NPEP branch from 924de7e to ebdabbc Compare August 1, 2023 10:55
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2023
@astoycos
Copy link
Member

astoycos commented Aug 1, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2023
danwinship
danwinship reviewed Aug 2, 2023
View reviewed changes
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
@shaneutt
Copy link
Member

/cc

@tssurya tssurya force-pushed the ANP-egress-control-NPEP branch from ebdabbc to 63f16dd Compare August 29, 2023 16:07
@k8s-ci-robot k8s-ci-robot requested a review from shaneutt August 29, 2023 16:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2023
danwinship
danwinship reviewed Sep 6, 2023
View reviewed changes
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Show resolved Hide resolved
@tssurya tssurya force-pushed the ANP-egress-control-NPEP branch 2 times, most recently from e0dca66 to 3899152 Compare September 13, 2023 10:03
@tssurya tssurya requested a review from danwinship September 14, 2023 10:45
danwinship
danwinship approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Some suggestions

npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
npep/npep-126-egress-traffic-control.md Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@tssurya
NPEP: Add support for egress traffic control
558c1d6 
Signed-off-by: Surya Seetharaman <[email protected]>
Acked-by: Dan Winship <[email protected]>
@tssurya tssurya force-pushed the ANP-egress-control-NPEP branch from 3899152 to 558c1d6 Compare September 20, 2023 11:59
@tssurya
Copy link
Contributor Author

tssurya commented Sep 20, 2023

@danwinship : I have addressed all your comments, thank you for the thorough reviews.

@astoycos
Copy link
Member

/unhold
/lgtm

Wahooo first NPEP in the books 🥳 🔥 🥇

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 639f674 into kubernetes-sigs:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulkjoshi rahulkjoshi rahulkjoshi left review comments

@npinaeva npinaeva npinaeva left review comments

@astoycos astoycos astoycos left review comments

@danwinship danwinship danwinship approved these changes

@Dyanngg Dyanngg Awaiting requested review from Dyanngg

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@astoycos astoycos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
AdminNetworkPolicyAPI: The road to Beta
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tssurya @astoycos @shaneutt @k8s-ci-robot @danwinship @rahulkjoshi @npinaeva