Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DomainName field to AdminNetworkPolicyEgressPeer #233

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add DomainName field to AdminNetworkPolicyEgressPeer #233

merged 1 commit into from
Jul 9, 2024

Conversation

rahulkjoshi
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @rahulkjoshi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit 4d8f8ea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6685922bd99fd900083d8d80
😎 Deploy Preview https://deploy-preview-233--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

astoycos
astoycos reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small PR, I like it!! Almost there :)

apis/v1alpha1/shared_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/shared_types.go Outdated Show resolved Hide resolved
apis/v1alpha1/shared_types.go Outdated Show resolved Hide resolved
@astoycos astoycos mentioned this pull request Jun 18, 2024
Closed
@astoycos
Copy link
Member

astoycos commented Jul 2, 2024 •
edited
Loading

Poke @rahulkjoshi Just need some small updates here 👍

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 3, 2024
@npinaeva
Copy link
Member

npinaeva commented Jul 4, 2024

/lgtm on the apis

astoycos
astoycos approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@astoycos astoycos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I think we need #238 for CI to pass and this to merge but otherwise thanks for all the efforts @rahulkjoshi!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astoycos, rahulkjoshi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit a5e3d29 into kubernetes-sigs:main Jul 9, 2024
10 checks passed
@astoycos astoycos mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadeepsen arkadeepsen arkadeepsen left review comments

@astoycos astoycos astoycos approved these changes

@danwinship danwinship Awaiting requested review from danwinship

Assignees

@astoycos astoycos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rahulkjoshi @k8s-ci-robot @astoycos @npinaeva @arkadeepsen