Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: [Policy Assistant] tests in github action #246

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

huntergregory
Copy link
Contributor

@huntergregory huntergregory commented Aug 8, 2024

Fixes #202.

GitHub action does the following:

  1. Trigger only on changes to cmd/policy-assistant/ directory
  2. Run unit tests
  3. Build binary
  4. Run commands for each analyze mode and make sure they exit with zero code

Unit tests

image

Integration tests

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2024
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for kubernetes-sigs-network-policy-api ready!

Name Link
🔨 Latest commit fb3beb6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-network-policy-api/deploys/6716d2ab3655a30008fbc428
😎 Deploy Preview https://deploy-preview-246--kubernetes-sigs-network-policy-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huntergregory huntergregory force-pushed the gh-action branch 2 times, most recently from e7875ca to fe09394 Compare August 8, 2024 18:27
@huntergregory
Copy link
Contributor Author

The GH action will fail until #244 and #245 merge.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2024
@huntergregory
Copy link
Contributor Author

huntergregory commented Oct 21, 2024

The GH action will fail until #244 and #245 merge.

GH action now passes. This PR should go in before #245. I removed tests that depend on #245

@huntergregory
Copy link
Contributor Author

Hey @astoycos @danwinship @Dyanngg 👋, could I get a review on this change introducing PR checks for policy assistant?

run: |
artifacts/cyclonus analyze --use-example-policies --mode explain

# - name: Run Integration Test - Probe Mode
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will uncomment in #245

@danwinship
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, huntergregory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit e066828 into kubernetes-sigs:main Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Policy Assistant] PR checks
3 participants