Wiring user identities #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ritikaguptams
force-pushed
the
wire-workload-id
branch
from
a92a1d5
to
f6c3641
Compare
k8s-ci-robot
added
size/S
ritikaguptams
force-pushed
the
wire-workload-id
branch
from
26b552a
to
48a3cb3
Compare
|
fixes #446 |
|
looks good, Can we add the repo-list and point the e2e testing script at it too? This would equivalent of https://github.com/kubernetes-sigs/windows-testing/blob/master/images/image-repo-list-private-registry but pointing at the new community ACR. |
ritikaguptams
force-pushed
the
wire-workload-id
branch
2 times, most recently
from
e0e52b5
to
b89a1ed
Compare
jsturtevant
reviewed
Jul 29, 2024
ritikaguptams
force-pushed
the
wire-workload-id
branch
from
b89a1ed
to
a523acd
Compare
jsturtevant
reviewed
Jul 29, 2024
ritikaguptams
force-pushed
the
wire-workload-id
branch
from
a523acd
to
72433d1
Compare
k8s-ci-robot
added
size/M
|
/test pull-e2e-capz-windows-2022-extension |
2 similar comments
|
/test pull-e2e-capz-windows-2022-extension |
|
/test pull-e2e-capz-windows-2022-extension |
ritikaguptams
force-pushed
the
wire-workload-id
branch
2 times, most recently
from
b6b2c21
to
01b364b
Compare
|
/assign @marosset |
ritikaguptams
force-pushed
the
wire-workload-id
branch
from
01b364b
to
75e0d60
Compare
marosset
reviewed
Jul 31, 2024
Signed-off-by: ritikaguptams <[email protected]>
ritikaguptams
force-pushed
the
wire-workload-id
branch
from
75e0d60
to
8dc7bb1
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset, ritikaguptams The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiring user identities to windows nodes