Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop setting HPAContianerMetrics feature-gate because it will be removed in v1.32 #468

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Stop setting HPAContianerMetrics feature-gate because it will be removed in v1.32 #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion capz/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export AZURE_SSH_PUBLIC_KEY_FILE="$HOME/.ssh/id_rsa.pub"
| `API_SERVER_FEATURE_GATES` | Comma-separated list of feature-gates and their values to pass to the kube-apiserver (Defaults to "") |
| `AZURE_LOCATION` | The azure region to deploy resources into. If not specified a random region will be selected) |
| `KUBERNETES_VERSION` | Valid values are `latest` (default) and `latest-1.xx` where x is valid kubernetes minor version such as `latest-1.24` |
| `NODE_FEATURE_GATES` | Comma-seperated list of feature-gates and their values to pass to the kubelet (Defaults to "HPAContainerMetrics=true") |
| `NODE_FEATURE_GATES` | Comma-seperated list of feature-gates and their values to pass to the kubelet (Defaults to "") |
| `NODE_MACHINE_TYPE` | The [Azure vm size](https://learn.microsoft.com/en-us/azure/virtual-machines/sizes) to use for the nodes |
| `RUN_SERIAL_TESTS` | If set to `true` then serial slow tests will be run with default ginkgo settings |
| `SKIP_CREATE` | Don't create a cluster. Must set `CLUSTER_NAME` and have current a workload cluster kubeconfig file with name `./"${CLUSTER_NAME}".kubeconfig` |
Expand Down
9 changes: 4 additions & 5 deletions capz/templates/gmsa-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
name: '{{ ds.meta_data["local_hostname"] }}'
Expand Down Expand Up @@ -198,14 +198,13 @@ spec:
apiServer:
extraArgs:
cloud-provider: external
feature-gates: ${API_SERVER_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${API_SERVER_FEATURE_GATES:-""}
timeoutForControlPlane: 20m
controllerManager:
extraArgs:
allocate-node-cidrs: "false"
cloud-provider: external
cluster-name: ${CLUSTER_NAME}
feature-gates: HPAContainerMetrics=true
v: "4"
etcd:
local:
Expand Down Expand Up @@ -321,13 +320,13 @@ spec:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
mounts:
- - LABEL=etcd_disk
Expand Down
9 changes: 4 additions & 5 deletions capz/templates/gmsa-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
name: '{{ ds.meta_data["local_hostname"] }}'
Expand Down Expand Up @@ -195,14 +195,13 @@ spec:
apiServer:
extraArgs:
cloud-provider: external
feature-gates: ${API_SERVER_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${API_SERVER_FEATURE_GATES:-""}
timeoutForControlPlane: 20m
controllerManager:
extraArgs:
allocate-node-cidrs: "false"
cloud-provider: external
cluster-name: ${CLUSTER_NAME}
feature-gates: HPAContainerMetrics=true
v: "4"
etcd:
local:
Expand Down Expand Up @@ -308,13 +307,13 @@ spec:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
mounts:
- - LABEL=etcd_disk
Expand Down
9 changes: 4 additions & 5 deletions capz/templates/shared-image-gallery-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
name: '{{ ds.meta_data["local_hostname"] }}'
Expand Down Expand Up @@ -204,14 +204,13 @@ spec:
apiServer:
extraArgs:
cloud-provider: external
feature-gates: ${API_SERVER_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${API_SERVER_FEATURE_GATES:-""}
timeoutForControlPlane: 20m
controllerManager:
extraArgs:
allocate-node-cidrs: "false"
cloud-provider: external
cluster-name: ${CLUSTER_NAME}
feature-gates: HPAContainerMetrics=true
v: "4"
etcd:
local:
Expand Down Expand Up @@ -327,13 +326,13 @@ spec:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
mounts:
- - LABEL=etcd_disk
Expand Down
9 changes: 4 additions & 5 deletions capz/templates/windows-base.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
name: '{{ ds.meta_data["local_hostname"] }}'
Expand Down Expand Up @@ -164,14 +164,13 @@ spec:
apiServer:
extraArgs:
cloud-provider: external
feature-gates: ${API_SERVER_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${API_SERVER_FEATURE_GATES:-""}
timeoutForControlPlane: 20m
controllerManager:
extraArgs:
allocate-node-cidrs: "false"
cloud-provider: external
cluster-name: ${CLUSTER_NAME}
feature-gates: HPAContainerMetrics=true
v: "4"
etcd:
local:
Expand Down Expand Up @@ -225,13 +224,13 @@ spec:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
mounts:
- - LABEL=etcd_disk
Expand Down
9 changes: 4 additions & 5 deletions capz/templates/windows-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
name: '{{ ds.meta_data["local_hostname"] }}'
Expand Down Expand Up @@ -198,14 +198,13 @@ spec:
apiServer:
extraArgs:
cloud-provider: external
feature-gates: ${API_SERVER_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${API_SERVER_FEATURE_GATES:-""}
timeoutForControlPlane: 20m
controllerManager:
extraArgs:
allocate-node-cidrs: "false"
cloud-provider: external
cluster-name: ${CLUSTER_NAME}
feature-gates: HPAContainerMetrics=true
v: "4"
etcd:
local:
Expand Down Expand Up @@ -321,13 +320,13 @@ spec:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
mounts:
- - LABEL=etcd_disk
Expand Down
9 changes: 4 additions & 5 deletions capz/templates/windows-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ spec:
criSocket: npipe:////./pipe/containerd-containerd
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
v: "2"
windows-priorityclass: ABOVE_NORMAL_PRIORITY_CLASS
name: '{{ ds.meta_data["local_hostname"] }}'
Expand Down Expand Up @@ -195,14 +195,13 @@ spec:
apiServer:
extraArgs:
cloud-provider: external
feature-gates: ${API_SERVER_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${API_SERVER_FEATURE_GATES:-""}
timeoutForControlPlane: 20m
controllerManager:
extraArgs:
allocate-node-cidrs: "false"
cloud-provider: external
cluster-name: ${CLUSTER_NAME}
feature-gates: HPAContainerMetrics=true
v: "4"
etcd:
local:
Expand Down Expand Up @@ -308,13 +307,13 @@ spec:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
joinConfiguration:
nodeRegistration:
kubeletExtraArgs:
cloud-provider: external
feature-gates: ${NODE_FEATURE_GATES:-"HPAContainerMetrics=true"}
feature-gates: ${NODE_FEATURE_GATES:-""}
name: '{{ ds.meta_data["local_hostname"] }}'
mounts:
- - LABEL=etcd_disk
Expand Down
Loading