Move to compute gallery #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAPZ is now publishing images to community gallery that lives in the CNCF subscription. See https://capz.sigs.k8s.io/self-managed/custom-images.html?highlight=computeGallery#using-azure-community-gallery and kubernetes-sigs/cluster-api-provider-azure#5167. Signed-off-by: James Sturtevant <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
Signed-off-by: James Sturtevant <[email protected]>
|
fyi @iankingori @TinaMor |
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
move-to-compute-gallery
branch
from
3c9a760 to
e307a17
Compare
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
move-to-compute-gallery
branch
from
e307a17 to
44abfd6
Compare
Signed-off-by: James Sturtevant <[email protected]>
iankingori
reviewed
Jan 7, 2025
| @@ -503,7 +508,7 @@ log() { | |||
|
|
|||
| # all test regions must support AvailabilityZones | |||
| get_random_region() { | |||
| local REGIONS=("australiaeast" "canadacentral" "eastus" "eastus2" "northeurope" "uksouth" "westus2" "northcentralus") | |||
| local REGIONS=("australiaeast" "canadacentral" "francecentral" "germanywestcentral" "northeurope" "switzerlandnorth" "uksouth") | |||
There was a problem hiding this comment.
I hit some inconsistencies with image replication across the different regions, and locked to northcentralus till I'd had a chance to review it.
There was a problem hiding this comment.
iankingori
approved these changes
Jan 7, 2025
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iankingori, jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAPZ is now publishing images to community gallery that lives in the CNCF subscription. See https://capz.sigs.k8s.io/self-managed/custom-images.html?highlight=computeGallery#using-azure-community-gallery and kubernetes-sigs/cluster-api-provider-azure#5167.
This also allows us to start to use the Windows server 2025 image.