-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Support multiple profiles #6545
base: master
Are you sure you want to change the base?
feature: Support multiple profiles #6545
Conversation
/ok-to-test |
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
Overall this looks good to me, modulo the backward compatibility aspect of failing on unknown scheduler names. @alculquicondor I wonder if you would mind doing a quick sanity check on changes in schedulerbased.go to see if there are any potential problems with initializing framework that way from CA? I don't see anything, but you have much more expertise here. |
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/simulator/predicatechecker/schedulerbased.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM from scheduler perspective
/assign @MaciekPytel Looks like you were reviewing this already, can you follow up? Is it ok to merge now? |
Co-authored-by: Aldo Culquicondor <[email protected]>
6cac2ad
to
d5f4367
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: daimaxiaxie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
The cluster scheduler can use multiple profiles to perform different scheduling for different pods. However, the current Cluster Autoscaler only supports one profile, which will lead to inaccurate scale up and down.
Feature issue #6544
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: