-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler-release-1.27] allow customizing user agent for Azure cluster-autoscaler provider #7056
Conversation
@k8s-infra-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
hold till CA 1.31 release /hold |
Why? |
Hi @comtalyst, as per the following comment, we can cherry-pick the #7033 after CA 1.31 release.
|
@Shubham82 That comment about cherry-picking was related to a different set of changes. There shouldn't be anything hold this up from being merged before 1.31. /hold cancel |
Hi @nojnhuh, ok Maybe I missed something here, but I'm just wondering then why this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I approved but most of these still wont get in without that azure e2e pipeline fix getting into these release branches |
e254d80
into
kubernetes:cluster-autoscaler-release-1.27
This is an automated cherry-pick of #7033
/assign nojnhuh