CA: fix update-deps.sh, bump k8s dependencies to v1.33.0-alpha.0 #7538
Conversation
There doesn't seem to be any benefit to tidying after getting every dependency pkg. And trying to tidy after every get seems bugged: * Some of the k8s.io dependencies depend on each other. For example k8s.io/client-go depends on k8s.io/api. * We bump k8s.io/api to a new version, and that version removes some pkg (e.g. replaces v1alpha1 with v1alpha2), that some other dependency (e.g. k8s.io/client-go) requires. * If we try to tidy immediately after getting k8s.io/api, this can fail because the required new k8s.io/api version doesn't have the removed pkg that k8s.io/client-go (still at a lower version since we haven't processed it yet) requires. Getting all of the dependencies at the new versions first, and then tidying once afterwards solves this issue.
k8s-ci-robot
added
kind/cleanup
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| sigs.k8s.io/structured-merge-diff/v4 v4.4.1 | ||
| github.com/onsi/ginkgo/v2 v2.21.0 | ||
| github.com/onsi/gomega v1.35.1 | ||
| k8s.io/apimachinery v0.33.0-alpha.0 |
There was a problem hiding this comment.
wouldn't this tag be more appropriate?:
There was a problem hiding this comment.
It definitely would until we release 1.32 CA, but the rc tags aren't mirrored in the staged k8s.io repos for some reason (see https://github.com/kubernetes/api/tags), so update-deps.sh doesn't work with that tag.
v1.33.0-alpha.0 should be okay though, if I'm looking correctly v1.32.0-rc.0 only has an empty release commit on top of v1.33.0-alpha.0:
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump CA k8s.io dependencies to the newest k/k master tag
v1.33.0-alpha.0. This is needed to bring kubernetes/kubernetes#127904 in so that CA can integrate with DRA scheduler plugin.I ran into an
update-deps.shcorner case, so there's a small fix for that as well (described in the commit message).Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @jackfrancis