Skip to content

feat: add evictAfterOOMThreshold per vpa #8692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add evictAfterOOMThreshold per vpa #8692

wants to merge 2 commits into from

Conversation

@omerap12
Copy link
Member

@omerap12 omerap12 commented Oct 26, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

evictAfterOOMThreshold is now per vpa

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[AEP]: https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler/enhancements/8026-per-vpa-component-configuration

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area labels Oct 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omerap12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler labels Oct 26, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-area labels Oct 26, 2025
@omerap12 omerap12 force-pushed the AEP-8026-evictAfterOOMThreshold branch from 4a53458 to d1d4fb5 Compare October 26, 2025 10:12
adrianmoisey
adrianmoisey reviewed Oct 31, 2025
View reviewed changes
vertical-pod-autoscaler/pkg/apis/autoscaling.k8s.io/v1/types.go
Comment on lines +49 to +50
// +kubebuilder:printcolumn:name="MinReplicas",type="integer",JSONPath=".spec.updatePolicy.minReplicas",priority=1
// +kubebuilder:printcolumn:name="OOMThreshold",type="string",JSONPath=".spec.updatePolicy.evictAfterOOMThreshold",priority=1
Copy link
Member

@adrianmoisey adrianmoisey Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like this!

adrianmoisey
adrianmoisey reviewed Oct 31, 2025
View reviewed changes
vertical-pod-autoscaler/e2e/utils/common.go
HamsterLabels, /*podLabels*/
GetHamsterContainerNameByIndex(0), /*imageName*/
"registry.k8s.io/ubuntu-slim:0.14", /*image*/
"ubuntu:25.10", /*image*/
Copy link
Member

@adrianmoisey adrianmoisey Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick grep of the kubernetes codebase, and I see they use ubuntu:latest
Unsure if it really matters though

Copy link
Member Author

@omerap12 omerap12 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I always prefer to set a specific version rather than latest, but no strong opinions here

adrianmoisey
adrianmoisey reviewed Oct 31, 2025
View reviewed changes
@omerap12
Copy link
Member Author

omerap12 commented Oct 31, 2025

/test pull-autoscaling-e2e-vpa-actuation

@omerap12 omerap12 force-pushed the AEP-8026-evictAfterOOMThreshold branch from a65c877 to 51e419d Compare October 31, 2025 11:28
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 31, 2025
@omerap12
Copy link
Member Author

omerap12 commented Oct 31, 2025

/retest

@omerap12
Copy link
Member Author

omerap12 commented Oct 31, 2025

/test pull-autoscaling-e2e-vpa-updater

@omerap12
Copy link
Member Author

omerap12 commented Oct 31, 2025

/test pull-autoscaling-e2e-vpa-recommender

@adrianmoisey
Copy link
Member

adrianmoisey commented Nov 3, 2025

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 3, 2025
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 3, 2025

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

adrianmoisey
adrianmoisey reviewed Nov 4, 2025
View reviewed changes
vertical-pod-autoscaler/e2e/v1/admission_controller.go
}, 3*time.Minute, 5*time.Second).Should(gomega.BeTrue(), "Webhook was not registered in the cluster")
}

var _ = AdmissionControllerE2eDescribe("Admission-controller", func() {
Copy link
Member

@adrianmoisey adrianmoisey Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the tests in this block look like they're dupes of tests higher-up in the file

adrianmoisey
adrianmoisey reviewed Nov 4, 2025
View reviewed changes
vertical-pod-autoscaler/e2e/v1/updater.go
gomega.Expect(err).NotTo(gomega.HaveOccurred())
gomega.Expect(len(podList.Items)).To(gomega.BeNumerically(">", 0))

// verySmallThreshold := 1 * time.Nanosecond
Copy link
Member

@adrianmoisey adrianmoisey Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded comment?

Copy link
Member

@adrianmoisey adrianmoisey Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think this was supposed to be used on line 265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrianmoisey adrianmoisey adrianmoisey left review comments

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omerap12 @k8s-ci-robot @adrianmoisey @k8s-triage-robot