Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.28.1] 1.28.1 release #2426

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[1.28.1] 1.28.1 release #2426

merged 2 commits into from
Oct 19, 2023

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Oct 11, 2023 •
edited
Loading

What this PR does / why we need it:

This PR bumps a release version for manifests and docs using a new hack/bump-release.sh script

Release note:

NONE

@kayrus kayrus requested review from dulek, mdbooth and zetaab October 11, 2023 21:30
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot requested a review from jichenjc October 11, 2023 21:30
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2023
@jichenjc
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
zetaab
zetaab requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are missing one file https://github.com/kayrus/cloud-provider-openstack/blob/r128/examples/webhook/keystone-deployment.yaml#L21 otherwise looks good! If you can fix that

@kayrus
Copy link
Contributor Author

kayrus commented Oct 12, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@kayrus kayrus force-pushed the r128 branch 2 times, most recently from 2b8054a to 6cd874f Compare October 12, 2023 17:37
@kayrus kayrus requested a review from zetaab October 12, 2023 17:40
zetaab
zetaab approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2023
@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

/test openstack-cloud-controller-manager-e2e-test

Looks like k3s update breaks CI?

@k8s-ci-robot
Copy link
Contributor

@dulek: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test openstack-cloud-controller-manager-e2e-test-release-128
  • /test openstack-cloud-csi-cinder-e2e-test-release-128
  • /test openstack-cloud-csi-cinder-sanity-test-release-128
  • /test openstack-cloud-csi-manila-e2e-test-release-128
  • /test openstack-cloud-csi-manila-sanity-test-release-128
  • /test openstack-cloud-keystone-authentication-authorization-test-release-128
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run the following jobs that were automatically triggered:

  • openstack-cloud-csi-cinder-e2e-test-release-128
  • pull-cloud-provider-openstack-check
  • pull-cloud-provider-openstack-test

In response to this:

/test openstack-cloud-controller-manager-e2e-test

Looks like k3s update breaks CI?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

/test openstack-cloud-controller-manager-e2e-test-release-128

@kayrus
Copy link
Contributor Author

kayrus commented Oct 13, 2023

@dulek yes, and I wonder why.

@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

/test openstack-cloud-controller-manager-e2e-test-release-128

DevStack haven't deployed.

@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test ?

@k8s-ci-robot
Copy link
Contributor

@kayrus: The following commands are available to trigger required jobs:

  • /test openstack-cloud-controller-manager-e2e-test-release-128
  • /test openstack-cloud-csi-cinder-e2e-test-release-128
  • /test openstack-cloud-csi-cinder-sanity-test-release-128
  • /test openstack-cloud-csi-manila-e2e-test-release-128
  • /test openstack-cloud-csi-manila-sanity-test-release-128
  • /test openstack-cloud-keystone-authentication-authorization-test-release-128
  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run the following jobs that were automatically triggered:

  • openstack-cloud-csi-cinder-e2e-test-release-128
  • pull-cloud-provider-openstack-check
  • pull-cloud-provider-openstack-test

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kayrus
Copy link
Contributor Author

kayrus commented Oct 19, 2023

/test openstack-cloud-controller-manager-e2e-test-release-128
/test openstack-cloud-csi-cinder-e2e-test-release-128
/test openstack-cloud-csi-cinder-sanity-test-release-128
/test openstack-cloud-csi-manila-e2e-test-release-128
/test openstack-cloud-csi-manila-sanity-test-release-128
/test openstack-cloud-keystone-authentication-authorization-test-release-128
/test pull-cloud-provider-openstack-check
/test pull-cloud-provider-openstack-test

@zetaab
Copy link
Member

zetaab commented Oct 19, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zetaab
Copy link
Member

zetaab commented Oct 19, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 86510a9 into kubernetes:release-1.28 Oct 19, 2023
1 check passed
@kayrus kayrus deleted the r128 branch October 19, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@dulek dulek Awaiting requested review from dulek

@mdbooth mdbooth Awaiting requested review from mdbooth

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kayrus @jichenjc @dulek @k8s-ci-robot @zetaab