Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut 1.28.2 #2559

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Cut 1.28.2 #2559

merged 1 commit into from
Mar 4, 2024

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Feb 29, 2024

What this PR does / why we need it:
This is to include fixes to #2531 in a release.

Which issue this PR fixes(if applicable):
fixes #2531

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 29, 2024
@dulek
Cut 1.28.2
115c3e5 
This is to include fixes to kubernetes#2531 in a release.
@dulek
Copy link
Contributor Author

dulek commented Feb 29, 2024

/retest

Looks like we just suddenly lost a VM, shouldn't be caused by this patch.

@dulek
Copy link
Contributor Author

dulek commented Mar 1, 2024

@kayrus, @jichenjc, @zetaab: This is ready for a review.

kayrus
kayrus approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@kayrus kayrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Do you plan to make 1.27 release as well?

@dulek
Copy link
Contributor Author

dulek commented Mar 1, 2024

LGTM, thanks! Do you plan to make 1.27 release as well?

I can do it, though here I'm trying to just fix broken container shipped in 1.28.

@zetaab
Copy link
Member

zetaab commented Mar 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2024
@jichenjc
Copy link
Contributor

jichenjc commented Mar 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3c11e03 into kubernetes:release-1.28 Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayrus kayrus kayrus approved these changes

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dulek @zetaab @k8s-ci-robot @jichenjc @kayrus