Skip to content

Commit

Permalink
ci: Fix CodeQL check and ignore codecov token error (#8827)
Browse files Browse the repository at this point in the history
* Fix CodeQL check

As of now, we need to manually setup golang for 1.22.
github/codeql#15647 (comment)

* ci: ignore Codecov token not found error

PR from dependabot causes an error, so comment this out until the problem is resolved.
See codecov/codecov-action#1274

* Remove fail_ci_if_error option

Having reports uploaded is not impotant, especially PR for dependency update.
See following about bug for this option:
codecov/codecov-action#1274
  • Loading branch information
shu-mutou authored Apr 2, 2024
1 parent 759ab97 commit 082b1ae
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/setup-go@v5
with:
go-version-file: modules/api/go.mod
check-latest: true
- uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
Expand Down Expand Up @@ -132,7 +136,6 @@ jobs:
- uses: codecov/[email protected]
with:
directory: ./.tmp
fail_ci_if_error: true
token: ${{ secrets.CODECOV_TOKEN }}

# TODO: needs to be fixed
Expand Down

0 comments on commit 082b1ae

Please sign in to comment.