-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow hiding "All namespaces" in namespaces dropdown list #9547
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avanish23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @avanish23! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9547 +/- ##
==========================================
- Coverage 36.86% 36.85% -0.02%
==========================================
Files 283 283
Lines 14100 14102 +2
Branches 183 202 +19
==========================================
- Hits 5198 5197 -1
+ Misses 8680 8630 -50
- Partials 222 275 +53 |
This feels like a hacky workaround. We are working on introducing a dynamic cache that should greatly improve responsiveness in large clusters. However, storing cached data will probably require greater memory limits. |
/retest |
@avanish23: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind feature |
Yes, I agree. This could be treated as a temporary workaround until we have the fix you are talking about. |
Ye, I don't like introducing temporary flags that will be deprecated and removed shortly after being introduced. It can be confusing. Also, we are trying to avoid container flags that directly manipulate the UI. It should probably be done in a different way. Possibly via settings. |
Ok, this makes sense to be using setting instead. I think it should be added as part of the global setting. Update: I have made changes to use the settings instead of the container flags. |
6f420b7
to
526683e
Compare
2fba2b8
to
4bd48b6
Compare
For some reason namespace switch on settings view is always set to false even after switching to true and saving. Probably the value read from settings config map is not properly propagated to it. |
a68ab27
to
0d5f653
Compare
(cherry picked from commit 534a365efcf56aa7b3592b55e0885d021f97688c) added translation; bumped up charts version;fixed lint revert chart version bumpup add hideAllNamespaces in externalSettings func fix conflict
6fa243c
to
c224e63
Compare
Closes #8894
With this PR a new option is enabled in the global setting to hide the all-namespaces option in the namespaces dropdown menu in UI.
Briefly explain why this is required
Hides all namespace fields in the namespace selection dropbox to avoid accidental selection in large clusters and prevent OOM errors.
/kind feature