Always Honor PersistentVolume Reclaim Policy

[xing-yang]

Enhancement Description

• One-line enhancement description (can be used as a release note): PersistentVolume reclaim policy should always be honored
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy
• Discussion Link: volume leaks when PVC is deleted when associated PV is in the terminating state kubernetes-csi/external-provisioner#546
• Primary contact (assignee): @deepakkinni @xing-yang
• Responsible SIGs: SIG-Storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.31
  • Stable release target (x.y): 1.32
• Alpha
  • KEP (k/enhancements) update PR(s): Honor Persistent Volume Reclaim Policy #2680
  • Code (k/k) update PR(s): PV controller changes to support PV Deletion protection finalizer kubernetes#105773
  • Docs (k/website) update(s): PR submitted
• Beta
  • KEP (k/enhancements) update PR(s): promote KEP-2644 to beta in 1.31 #4397
  • e2e tests: add e2e test for HonorPVReclaimPolicy kubernetes#123151
  • Code (k/k) update PR(s): Promote HonorPVReclaimPolicy to beta and enable it by default kubernetes#124842
  • Docs (k/website) update(s): promote HonorPVReclaimPolicy to beta website#46794
  • Blog: Blogpost for honor PV reclaim policy fix moving to Beta website#46890

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[xing-yang]

/sig storage

[JamesLaverack]

/milestone v1.22

[gracenng]

Hi @xing-yang, 1.22 Enhancements Shadow here.

The KEP looks all good, however, the status of the KEP on Enhancement track sheet will be at risk until the KEP is merged into master.

Thanks!

[gracenng]

Hi @xing-yang 👋 1.22 Enhancements shadow here.
To help SIG's be aware of their workload, I just wanted to check to see if SIG-Storage will need to do anything for this enhancement and if so, are they OK with it?
Thanks!

[JamesLaverack]

Hi @deepakkinni, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[xing-yang]

KEP is here but not merged yet: #2680

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[xing-yang]

/milestone v1.23

[lauralorenz]

Hi @xing-yang, @deepakkinni! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09.

If I understand correctly, you are targeting alpha stage in release 1.23.

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable (filled out in PR, not merged)
• KEP has a test plan section filled out. (filled out in PR, not merged)
• KEP has up to date graduation criteria. (filled out in PR, not merged)
• KEP has a production readiness review that has been completed and merged into k/enhancements. (filled out in PR, not merged)

Starting with 1.23, we have implemented a soft freeze on production readiness reviews beginning tomorrow, Thursday 09/02. It looks like you already have the questionnaire filled out in your PR and have a PRR reviewer associated, so you are on track for tomorrow's soft freeze!

Thanks!

[ramrodo]

Hi @xing-yang, @deepakkinni 👋 1.23 Docs shadow here.

This enhancement is marked as Needs Docs for the 1.23 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.23 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thu November 18, 11:59 PM PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thanks!

[xing-yang]

Hi @ramrodo,
We looked at this again and decided that this does not need a doc change. Can you please help remove "Need Docs" from the feature tracking sheet? Thanks!

[xing-yang]

Also the required in-tree PR for this KEP is merged: kubernetes/kubernetes#105773
We are on-track for 1.23.

[lauralorenz]

Hi @xing-yang, enhancements 1.23 shadow again! Just double checking everything before code freeze TOMORROW at 6:00 pm PST on Tuesday, November 16. Please ensure that

• all PRs to the Kubernetes repo related to your enhancement are fully merged by the code freeze deadline (It looks like you've already got PV controller changes to support PV Deletion protection finalizer kubernetes#105773 merged. 🎉)
• have a documentation placeholder PR open by Thursday, November 18. (Based on the comment above Always Honor PersistentVolume Reclaim Policy #2644 (comment) it looks like you are expecting not to open one but will let @ramrodo speak to that from their side.)

Thanks!!

[sreeram-venkitesh]

Hello @xing-yang 👋, v1.30 Enhancements team here!

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage beta for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.30.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Update the latest-milestone to 1.30, beta milestone to 1.30 and the stage to be beta in the kep.yaml file and get them merged into k/enhancements.
• Make sure that your KEP readme file is using the latest template. If not, please update it to the latest template and get it merged to k/enhancements as well.

The status of this enhancement is marked as at risk for enhancement freeze. Thank you!

[xing-yang]

@sreeram-venkitesh Thanks for the ping! Most likely we'll miss the 1.30 deadlines as we need to add e2e tests first before the KEP merge deadline.
cc @deepakkinni

[sreeram-venkitesh]

@xing-yang Thanks for the update! I've updated this KEP to be deferred for this cycle.

CC: @salehsedghpour

[salehsedghpour]

/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[xing-yang]

/remove-lifecycle stale

[prianna]

Hello @xing-yang 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting stage beta for v1.31 (correct me if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has submitted a production readiness review request for approval and has a reviewer assigned.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[MaryamTavakkoli]

Hello @deepakkinni 👋, 1.31 Docs Shadow here.
Does this enhancement work planned for 1.31 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, June 27, 2024, 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!

[carlory]

@MaryamTavakkoli doc pr is kubernetes/website#46794

[edithturn]

Hello @deepakkinni!

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[xing-yang]

Hi @edithturn, a placeholder blog PR is submitted here: kubernetes/website#46890

[edithturn]

Hi @edithturn, a placeholder blog PR is submitted here: kubernetes/website#46890

Hi @xing-yang, thank you for your response; please let me know if you need any help!

[prianna]

Hey again @xing-yang 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

• Promote HonorPVReclaimPolicy to beta and enable it by default kubernetes#124842
• add e2e test for HonorPVReclaimPolicy kubernetes#123151

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in