Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blogpost for honor PV reclaim policy fix moving to Beta #46890

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Blogpost for honor PV reclaim policy fix moving to Beta #46890

merged 1 commit into from
Aug 14, 2024

Conversation

deepakkinni
Copy link
Member

@deepakkinni deepakkinni commented Jun 19, 2024 •
edited
Loading

This PR is a blog post explaining the change in behavior described in the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy

Most of the content is originally from #30556, with some additional updates.

cc: @xing-yang @jsafrane @carlory

KEP: kubernetes/enhancements#2644

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 19, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: deepakkinni / name: Deepak Kinni (cdef287)

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 19, 2024 21:04
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2024
@deepakkinni deepakkinni force-pushed the doc_pv_reclaim_v1 branch 3 times, most recently from 08f55fb to 04622ec Compare June 19, 2024 21:26
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 19, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cdef287
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66b2c2f25fd6f10008ad633e
😎 Deploy Preview https://deploy-preview-46890--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xing-yang xing-yang mentioned this pull request Jun 20, 2024
Open
10 tasks
@sftim
Copy link
Contributor

sftim commented Jun 23, 2024

/hold

pending assignment of publication date (by release comms)

we'll also keep this held until the v1.31 release has happened

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2024
@MaryamTavakkoli
Copy link
Contributor

Hello @deepakkinni 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
@deepakkinni deepakkinni changed the title [WIP] Blogpost for honor PV reclaim policy fix moving to Beta Blogpost for honor PV reclaim policy fix moving to Beta Jul 15, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
@edithturn
Copy link
Contributor

Hello @deepakkinni, it's Edith Puclla from the 1.31 Release comms team.

A friendly reminder that the deadline for the blog to be ready for review is July 26, 2024.

Let me know if there's anything we can do to help with content, review, or anything else! 🙂

@carlory
Copy link
Member

carlory commented Jul 16, 2024 •
edited
Loading

@deepakkinni #46794 has changed the docs directory. please remove those changes. We should only contain the blog in this PR.

sorry, I forget to cc you in that PR.

@sftim
Copy link
Contributor

sftim commented Jul 18, 2024

@edithturn do you have a publication date to assign yet (even a tentative one)?

@edithturn
Copy link
Contributor

edithturn commented Jul 26, 2024 •
edited
Loading

Hello @deepakkinni ,

Just a friendly reminder that the review date is today. When you have a moment, could you please give us an update? I'd love to mark it as "ready for review." Let me know if there's anything I can assist you with 🙂

Thanks a bunch!

Edith Puclla
Comms Shadow

@deepakkinni
Copy link
Member Author

Hello @deepakkinni ,

Just a friendly reminder that the review date is today. When you have a moment, could you please give us an update? I'd love to mark it as "ready for review." Let me know if there's anything I can assist you with 🙂

Thanks a bunch!

Edith Puclla Comms Shadow

Sorry for the delayed reply. It's ready for review.

tengqm
tengqm reviewed Jul 27, 2024
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits.

content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2024-06-19-Honor-PV-Reclaim-Policy-Beta.md Outdated Show resolved Hide resolved
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d4b8aa0aa387d88ae9b9f3d86727409f13b49c5

@xing-yang
Copy link
Contributor

/lgtm

@T-Lakshmi
Copy link
Contributor

Preview page

Thanks @deepakkinni

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@deepakkinni
Add blogpost for honor PV reclaim policy fix moving to Beta
cdef287 
Co-authored-by: 杨朱 · Kiki <[email protected]>
Co-authored-by: Nate W <[email protected]>
Co-authored-by: Qiming Teng <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>

Signed-off-by: Deepak Kinni <[email protected]>
@a-mccarthy
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 64acddfcd06ae34c9638ac3a4bffb0c3496d55ce

@sftim
Copy link
Contributor

sftim commented Aug 14, 2024

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavishpal, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 411c31a into kubernetes:main Aug 14, 2024
6 checks passed
@lavishpal lavishpal mentioned this pull request Sep 18, 2024
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@nate-double-u nate-double-u nate-double-u left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@Princesso Princesso Princesso left review comments

@a-mccarthy a-mccarthy a-mccarthy left review comments

@sftim sftim sftim left review comments

@carlory carlory carlory left review comments

@lavishpal lavishpal lavishpal approved these changes

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@tengqm tengqm Awaiting requested review from tengqm

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

@tengqm tengqm

@a-mccarthy a-mccarthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.