Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retroactive KEP for WinDSR and WinOverlay feature-gates #5100

Open
1 of 5 tasks
marosset opened this issue Jan 28, 2025 · 7 comments
Open
1 of 5 tasks

Retroactive KEP for WinDSR and WinOverlay feature-gates #5100

marosset opened this issue Jan 28, 2025 · 7 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@marosset
Copy link
Contributor

marosset commented Jan 28, 2025

Enhancement Description

  • One-line enhancement description (can be used as a release note): Support DSR and Overlay networking in Windows kube-proxy

  • Kubernetes Enhancement Proposal:

  • Discussion Link: https://youtu.be/AqGmNKG1AHc?si=S-1kzNICabbWIfDW&t=614 (and previous community meetings)

  • Primary contact (assignee): @marosset

  • Responsible SIGs: Windows, Networking

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y): 1.14
    • Beta release target (x.y): 1.33
    • Stable release target (x.y):
  • Alpha

  • Beta

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 28, 2025
@marosset
Copy link
Contributor Author

/sig windows networking
/stage beta
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 28, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 28, 2025
@k8s-ci-robot
Copy link
Contributor

@marosset: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

/sig windows networking
/stage beta
/milestone v1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 28, 2025
@marosset
Copy link
Contributor Author

WinDSR and WinOverlay feature gates were added in K8s v1.14 and were introduced without a KEP.
Both of these features gates are stable and used in many production environments.
This enhancement will add a 'retroactive' KEP for DSR and Overlay support for Windows nodes documenting what the features enable and will be used to move the feature gates to stable in upcoming releases.

@marosset marosset added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 28, 2025
@marosset marosset self-assigned this Jan 28, 2025
@marosset
Copy link
Contributor Author

marosset commented Feb 3, 2025

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 3, 2025
@jenshu
Copy link

jenshu commented Feb 4, 2025

Hello @marosset 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • I see that you have a PR open with some of these updates. Please also make sure to add an approver for beta in the PRR file.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
@sftim
Copy link
Contributor

sftim commented Feb 10, 2025

Even though this is retroactive, the KEP title should explain the feature more than the retroactiveness. That makes https://www.kubernetes.dev/resources/keps/ most useful to readers.

@dipesh-rawat
Copy link
Member

Hi @marosset 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #5100 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: At risk for enhancements freeze
Development

No branches or pull requests

5 participants