5100: Adding retroactive KEP for WinDSR and WinOverlay #5112
+1,063
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/windows
k8s-ci-robot
added
sig/network
k8s-ci-robot
added
the
kind/kep
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
jsturtevant
reviewed
Feb 3, 2025
jsturtevant
reviewed
Feb 3, 2025
jsturtevant
reviewed
Feb 3, 2025
jsturtevant
reviewed
Feb 3, 2025
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
marosset
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
5 tasks
k8s-ci-robot
added
size/XXL
soltysh
reviewed
Feb 10, 2025
| - [ ] (R) Production readiness review approved | ||
| - [ ] "Implementation History" section is up-to-date for milestone | ||
| - [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io] | ||
| - [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes |
There was a problem hiding this comment.
Nit: make sure to check appropriate boxes.
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
| are missing a bunch of machinery and tooling and can't do that now. | ||
| --> | ||
|
|
||
| For DSR support yes, manual verification was done to ensure that DSR can be enabled and disabled on a node. |
There was a problem hiding this comment.
Please describe the manual testing performed, see https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs/README.md#were-upgrade-and-rollback-tested-was-the-upgrade-downgrade-upgrade-path-tested as an example.
|
|
||
| No | ||
|
|
||
| ### Troubleshooting |
| - when the KEP was retired or superseded | ||
| --> | ||
|
|
||
| ## Drawbacks |
Co-authored-by: Maciej Szulik <[email protected]>
Signed-off-by: Mark Rossetti <[email protected]>
Signed-off-by: Mark Rossetti <[email protected]>
avin3sh
reviewed
Feb 11, 2025
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
aravindhp
reviewed
Feb 11, 2025
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| #### GA | ||
|
|
||
| - 2 or more CNI solutions support overlay networking mode for Windows nodes. |
There was a problem hiding this comment.
I know OpenShift uses https://github.com/containernetworking/plugins that supports Windows overlay networking. Not sure if that counts here.
zylxjtu
reviewed
Feb 11, 2025
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
soltysh
reviewed
Feb 11, 2025
keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md
Outdated
Show resolved
Hide resolved
|
|
||
| For overlay, no, because the feature requires the cluster to be configured for overlay networking mode and cannot be enabled on a per-node basis. | ||
|
|
||
| For DSR, no, but they can be added. |
There was a problem hiding this comment.
Yes please. Even unit or integration tests are better than none.
Co-authored-by: Avinesh Singh <[email protected]> Co-authored-by: Aravindh Puthiyaparambil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/milestone v1.33
/sig windows network
/wip