KEP-1880: don't lock ServiceCIDR by default #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
approved
|
/assign @danwinship @thockin I think this is a good escape hatch that balance perfectly the capacity of having signal on users with the capacity for distros to decide to keep using the old allocators |
Change-Id: I54c537d25fe9f4a9488c535ff799f31b3e6ad03f
aojea
force-pushed
the
servicecidr_ga_not_lock_by_default
branch
from
42563e3 to
12f6f54
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line PR description: Graduate to GA KEP-1880 but don't lock it by default
Issue link: Multiple Service CIDRs #1880
Other comments: This change requires an action item on infrastructure providers or components that depend on the convention that the Service CIDR on the cluster was unique and immutables, also, the restriction of disabling beta APIs by default made that the signal is still low for a complex feature of this magnitude.
Not setting the feature gate locked by default allow infrastructure providers and users to still disable the feature gate without having to install webhooks or Validating Admission Policies.