Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2338 Graduate API gzip compression to GA #5070

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 22, 2025

  • One-line PR description: update GA version to v1.33 and add some history PRs and issues.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Jan 22, 2025

/cc @smarterclayton @ilackarms
/assign @liggitt

@jpbetz does this need a PRR review?

@k8s-ci-robot
Copy link
Contributor

@pacoxu: GitHub didn't allow me to request PR reviews from the following users: ilackarms.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @smarterclayton @ilackarms
/assign @liggitt

@jpbetz does this need a PRR review?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into two PRs?

  1. Tidy up what we have for beta (eg, record the feature gate)
  2. Graduate to GA. This can still target v1.33, right?

It feels odd to go from "feature gate not recorded properly" to "stable".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right, because all KEPs have a goal of general feature availability.

For GA, can we clean up the path? Maybe it's set and we have to live with it, but keps/sig-api-machinery/2338-API-gzip-compression-support/README.md would make more sense if feasible.


* Update the existing incomplete alpha API compression to:
* Only occur on API requests
* Only occur on very large responses (>128KB)
* Promote to beta and enable by default since this is a standard feature of HTTP servers
* Test at large scale to mitigate risk of regression, tune as necessary

### 1.17
### Revist Beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo; should be “revisit“

@sftim
Copy link
Contributor

sftim commented Jan 22, 2025

/retitle KEP-2338 Graduate API gzip compression to GA

@k8s-ci-robot k8s-ci-robot changed the title Graduate API gzip compression to GA KEP-2338 Graduate API gzip compression to GA Jan 22, 2025
@liggitt
Copy link
Member

liggitt commented Jan 22, 2025

I'm in favor of graduating this... the client opt-out bits and compression level reduction in the 1.25/1.26 timeframe seem to have addressed the concerns.

@jpbetz, can you review or delegate for PRR bits?

@jpbetz
Copy link
Contributor

jpbetz commented Jan 22, 2025

@pacoxu Looks like this KEP pre-dates the PRR review sections. Would you copy them in from the template and fill in the sections that apply to this GA promotion? (and double check that we didn't miss anything from the alpha/beta sections that should be considered?)

@pacoxu pacoxu mentioned this pull request Jan 23, 2025
13 tasks
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpbetz. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 23, 2025
@pacoxu
Copy link
Member Author

pacoxu commented Jan 23, 2025

@pacoxu Looks like this KEP pre-dates the PRR review sections. Would you copy them in from the template and fill in the sections that apply to this GA promotion? (and double check that we didn't miss anything from the alpha/beta sections that should be considered?)

I tried to add some comments for those questions.

plane? No.
- Will enabling / disabling the feature require downtime or reprovisioning
of a node? No.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please copy and answer all questions from the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants