-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2338 Graduate API gzip compression to GA #5070
base: master
Are you sure you want to change the base?
Conversation
pacoxu
commented
Jan 22, 2025
- One-line PR description: update GA version to v1.33 and add some history PRs and issues.
- Issue link: API gzip compression support #2338
- Other comments:
/cc @smarterclayton @ilackarms @jpbetz does this need a PRR review? |
@pacoxu: GitHub didn't allow me to request PR reviews from the following users: ilackarms. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this into two PRs?
- Tidy up what we have for beta (eg, record the feature gate)
- Graduate to GA. This can still target v1.33, right?
It feels odd to go from "feature gate not recorded properly" to "stable".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right, because all KEPs have a goal of general feature availability.
For GA, can we clean up the path? Maybe it's set and we have to live with it, but keps/sig-api-machinery/2338-API-gzip-compression-support/README.md
would make more sense if feasible.
|
||
* Update the existing incomplete alpha API compression to: | ||
* Only occur on API requests | ||
* Only occur on very large responses (>128KB) | ||
* Promote to beta and enable by default since this is a standard feature of HTTP servers | ||
* Test at large scale to mitigate risk of regression, tune as necessary | ||
|
||
### 1.17 | ||
### Revist Beta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo; should be “revisit“
/retitle KEP-2338 Graduate API gzip compression to GA |
I'm in favor of graduating this... the client opt-out bits and compression level reduction in the 1.25/1.26 timeframe seem to have addressed the concerns. @jpbetz, can you review or delegate for PRR bits? |
@pacoxu Looks like this KEP pre-dates the PRR review sections. Would you copy them in from the template and fill in the sections that apply to this GA promotion? (and double check that we didn't miss anything from the alpha/beta sections that should be considered?) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pacoxu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I tried to add some comments for those questions. |
plane? No. | ||
- Will enabling / disabling the feature require downtime or reprovisioning | ||
of a node? No. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please copy and answer all questions from the template.