Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark KEP-2395 as implemented #5178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

carlory
Copy link
Member

@carlory carlory commented Feb 18, 2025

  • One-line PR description: Mark KEP-2395 as implemented
  • Other comments: Update 2395-removing-in-tree-cloud-providers to stable status

@k8s-ci-robot k8s-ci-robot requested a review from elmiko February 18, 2025 09:35
@carlory
Copy link
Member Author

carlory commented Feb 18, 2025

If you are already working on this, feel free to close my PR.

/cc @dims @elmiko

kubernetes/kubernetes@7f9a0ef promoted the feature gates to GA. I'm not sure whether there is remaining work to do here because the prod-readiness of this KEP is not updated.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carlory
Once this PR has been reviewed and has the lgtm label, please assign cheftako, soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Feb 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims February 18, 2025 09:36
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 18, 2025
@elmiko
Copy link
Contributor

elmiko commented Feb 18, 2025

thank you @carlory for cleaning up the last bits of our mess 🙏

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants